Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2028613002: Have detached ScriptLoaders detach their PendingScripts. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken, Nate Chapin
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have detached ScriptLoaders detach their PendingScripts. A ScriptLoader that has become detached from its document will not execute the script once the script resource has loaded. If in such a detached state, make sure the ScriptLoader lets go of its PendingScript promptly. R= BUG= Committed: https://crrev.com/cb7d218fb4605744596dbb2b722f3e8934227093 Cr-Commit-Position: refs/heads/master@{#397106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. spent a long while trying to come up with a layout ...
4 years, 6 months ago (2016-06-01 08:46:08 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-06-01 11:08:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028613002/1
4 years, 6 months ago (2016-06-01 11:20:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 11:24:10 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 11:25:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb7d218fb4605744596dbb2b722f3e8934227093
Cr-Commit-Position: refs/heads/master@{#397106}

Powered by Google App Engine
This is Rietveld 408576698