Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2028603003: Fix Asan build. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix Asan build. Need the tools/memory directory in order for asan to find the blacklist during compilation. Committed: https://pdfium.googlesource.com/pdfium/+/fb96900eeea15b252245b0caf4330a5ade369172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-05-31 19:34:34 UTC) #2
Oliver Chang
lgtm. this is for GN, right?
4 years, 6 months ago (2016-05-31 19:37:16 UTC) #3
dsinclair
On 2016/05/31 19:37:16, Oliver Chang wrote: > lgtm. this is for GN, right? I'm building ...
4 years, 6 months ago (2016-05-31 19:38:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028603003/1
4 years, 6 months ago (2016-05-31 19:38:17 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:55:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fb96900eeea15b252245b0caf4330a5ade36...

Powered by Google App Engine
This is Rietveld 408576698