Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 2028573003: Implement gfx::Transform StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement gfx::Transform StructTraits This has test coverage through surfaces unittests, but I will add a standalone test in a separate patch. BUG=611802 Committed: https://crrev.com/b4185b229021653f1000f8224244bb65b36f31bc Cr-Commit-Position: refs/heads/master@{#397110}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Added a comment #

Patch Set 4 : Moved to ui/gfx/mojo #

Patch Set 5 : Add missing build file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -149 lines) Patch
M components/mus/public/cpp/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.cc View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M components/mus/public/cpp/surfaces/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/interfaces/quads.mojom View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/platform_display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mash/app_driver/BUILD.gn View 1 1 chunk +5 lines, -2 lines 0 comments Download
M mash/wm/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/geometry/mojo/geometry.mojom View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/gfx/mojo/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -17 lines 0 comments Download
D ui/gfx/mojo/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/gfx/mojo/mojo_transform_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
A + ui/gfx/mojo/transform.mojom View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
A ui/gfx/mojo/transform.typemap View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A ui/gfx/mojo/transform_struct_traits.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
D ui/gfx/mojo/transform_type_converters.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/gfx/mojo/transform_type_converters.cc View 1 chunk +0 lines, -33 lines 0 comments Download
A + ui/gfx/mojo/typemaps.gni View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/typemaps.gni View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Fady Samuel
+tsepez@ for ipc +danakj for ui/gfx +ben@ for everything else
4 years, 6 months ago (2016-05-31 21:52:27 UTC) #3
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-31 22:04:22 UTC) #4
Ben Goodger (Google)
OK now I see what you were talking about Fady. I think it makes sense ...
4 years, 6 months ago (2016-05-31 22:31:43 UTC) #5
Fady Samuel
On 2016/05/31 22:31:43, Ben Goodger (Google) wrote: > OK now I see what you were ...
4 years, 6 months ago (2016-05-31 23:38:02 UTC) #6
Fady Samuel
PTAL Ben, Dana. Thanks!
4 years, 6 months ago (2016-05-31 23:38:18 UTC) #7
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-01 01:50:28 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028573003/80001
4 years, 6 months ago (2016-06-01 04:15:05 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 07:10:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028573003/80001
4 years, 6 months ago (2016-06-01 12:09:10 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-01 12:13:40 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 12:15:38 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b4185b229021653f1000f8224244bb65b36f31bc
Cr-Commit-Position: refs/heads/master@{#397110}

Powered by Google App Engine
This is Rietveld 408576698