Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2028543003: mac/gn: Unbreak video_encode_accelerator_unittest after https://codereview.chromium.org/1818903004 (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
emircan, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Unbreak video_encode_accelerator_unittest after https://codereview.chromium.org/1818903004 A media/gpu header now includes a webrtc video_common header, so video_common now must be a public_dep, so that webrtc's include directories are passed to dependencies. BUG=616220 NOTRY=true Committed: https://crrev.com/ecd1a0d8c84582fc1f8c3f1cd78f73494c7d1a01 Cr-Commit-Position: refs/heads/master@{#397114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Nico
4 years, 6 months ago (2016-05-31 22:06:22 UTC) #2
Nico
+dalecurtis for owners If you like this, please cq+
4 years, 6 months ago (2016-05-31 22:07:17 UTC) #4
emircan
lgtm. Thanks.
4 years, 6 months ago (2016-05-31 22:11:14 UTC) #5
DaleCurtis
lgtm
4 years, 6 months ago (2016-05-31 22:21:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028543003/1
4 years, 6 months ago (2016-05-31 22:21:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/230959)
4 years, 6 months ago (2016-06-01 03:12:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028543003/1
4 years, 6 months ago (2016-06-01 12:34:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 12:38:31 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 12:39:54 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecd1a0d8c84582fc1f8c3f1cd78f73494c7d1a01
Cr-Commit-Position: refs/heads/master@{#397114}

Powered by Google App Engine
This is Rietveld 408576698