Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 202853005: A64: ElementsKind TODOs (Closed)

Created:
6 years, 9 months ago by m.m.capewell
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: ElementsKind TODOs Replace LoadElementsKind with LoadElementsKindFromMap, remove unneeded TODO in DoStringCharFromCode, improve constraints for DoCheckValue and improve code for ElementsKind checking in StoreArrayLiteralElementStub. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -54 lines) Patch
M src/a64/code-stubs-a64.cc View 3 chunks +18 lines, -14 lines 0 comments Download
M src/a64/lithium-a64.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/a64/lithium-a64.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/a64/macro-assembler-a64.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
m.m.capewell
6 years, 9 months ago (2014-03-18 11:06:16 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-18 12:57:13 UTC) #2
m.m.capewell
6 years, 9 months ago (2014-03-18 15:02:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698