Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2028513002: Set origin for DOMParser documents. (Closed)

Created:
4 years, 6 months ago by ramya.v
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews, dominicc+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set origin for DOMParser documents. BUG=615597 Committed: https://crrev.com/5bff3790459642ac05e4bfaf61fffec986050302 Cr-Commit-Position: refs/heads/master@{#397331}

Patch Set 1 #

Patch Set 2 : Adding testcase #

Total comments: 2

Patch Set 3 : Updated as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DOMParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ramya.v
PTAL! Thanks
4 years, 6 months ago (2016-05-31 09:30:13 UTC) #2
tkent
lgtm https://codereview.chromium.org/2028513002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html File third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html (right): https://codereview.chromium.org/2028513002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html#newcode6 third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html:6: assert_equals((new DOMParser).parseFromString("", "text/html").origin, "file://"); nit: "file://" should be ...
4 years, 6 months ago (2016-06-01 23:06:50 UTC) #3
ramya.v
https://codereview.chromium.org/2028513002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html File third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html (right): https://codereview.chromium.org/2028513002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html#newcode6 third_party/WebKit/LayoutTests/fast/dom/dom-parser-document-origin.html:6: assert_equals((new DOMParser).parseFromString("", "text/html").origin, "file://"); On 2016/06/01 23:06:49, tkent wrote: ...
4 years, 6 months ago (2016-06-02 03:47:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028513002/40001
4 years, 6 months ago (2016-06-02 03:47:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/222039)
4 years, 6 months ago (2016-06-02 04:06:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028513002/40001
4 years, 6 months ago (2016-06-02 05:56:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 07:36:02 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 07:37:36 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5bff3790459642ac05e4bfaf61fffec986050302
Cr-Commit-Position: refs/heads/master@{#397331}

Powered by Google App Engine
This is Rietveld 408576698