Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(103)

Issue 2028483002: Remove abstract classes for memory dumper (Closed)

Created:
4 years, 3 months ago by bashi
Modified:
4 years, 3 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, rwlbuis, krit, drott+blinkwatch_chromium.org, Justin Novosad, Rik, gavinp+loader_chromium.org, blink-reviews, ajuma+watch_chromium.org, Mads Ager (chromium), jbroman, pdr+graphicswatchlist_chromium.org, loading-reviews+fetch_chromium.org, Nate Chapin, danakj+watch_chromium.org, tyoshino+watch_chromium.org, f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove abstract classes for memory dumper WebProcessMemoryDump and WebMemoryAllocatorDump are abstract interfaces because they lived in public/platform. Now they live in platform so there is no reason to have such abstractions. Unify them with their impl classes. This CL also replaces WebString with String. BUG=605822 Committed: https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40 Cr-Commit-Position: refs/heads/master@{#396803}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -781 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/PurgeableVector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/WebMemoryAllocatorDump.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/platform/WebMemoryAllocatorDump.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/platform/WebProcessMemoryDump.h View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/WebKit/Source/platform/WebProcessMemoryDump.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/platform/web_memory_allocator_dump.h View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/web_memory_allocator_dump.cc View 1 chunk +12 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/platform/web_memory_allocator_dump_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/platform/web_memory_allocator_dump_impl.cc View 1 chunk +0 lines, -42 lines 0 comments Download
A third_party/WebKit/Source/platform/web_process_memory_dump.h View 1 chunk +171 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/web_process_memory_dump.cc View 7 chunks +50 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/platform/web_process_memory_dump_impl.h View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D third_party/WebKit/Source/platform/web_process_memory_dump_impl_test.cc View 1 chunk +0 lines, -139 lines 0 comments Download
A + third_party/WebKit/Source/platform/web_process_memory_dump_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bashi
PTAL? This would be the last CL for dumper related clean-up in blink.
4 years, 3 months ago (2016-05-31 05:31:04 UTC) #2
haraken
LGTM
4 years, 3 months ago (2016-05-31 05:32:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028483002/40001
4 years, 3 months ago (2016-05-31 05:37:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78939)
4 years, 3 months ago (2016-05-31 07:38:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028483002/40001
4 years, 3 months ago (2016-05-31 07:39:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-05-31 08:33:02 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 08:35:15 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40
Cr-Commit-Position: refs/heads/master@{#396803}

Powered by Google App Engine
This is Rietveld 408576698