Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Unified Diff: net/spdy/hpack/hpack_decoder.cc

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lint errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/hpack/hpack_decoder.h ('k') | net/spdy/hpack/hpack_decoder_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_decoder.cc
diff --git a/net/spdy/hpack/hpack_decoder.cc b/net/spdy/hpack/hpack_decoder.cc
index 5d2142689b5889d8613c0ecc3d3cd790c8c9c92e..c4a863a443ef9c088a72eaa7f60b26316eed4c5b 100644
--- a/net/spdy/hpack/hpack_decoder.cc
+++ b/net/spdy/hpack/hpack_decoder.cc
@@ -24,7 +24,6 @@ const char kCookieKey[] = "cookie";
HpackDecoder::HpackDecoder()
: handler_(nullptr),
total_header_bytes_(0),
- regular_header_seen_(false),
header_block_started_(false),
total_parsed_bytes_(0) {}
@@ -74,8 +73,6 @@ bool HpackDecoder::HandleControlFrameHeadersData(const char* headers_data,
}
bool HpackDecoder::HandleControlFrameHeadersComplete(size_t* compressed_len) {
- regular_header_seen_ = false;
-
if (compressed_len != nullptr) {
*compressed_len = total_parsed_bytes_;
}
@@ -100,17 +97,6 @@ bool HpackDecoder::HandleHeaderRepresentation(StringPiece name,
StringPiece value) {
total_header_bytes_ += name.size() + value.size();
- // Fail if pseudo-header follows regular header.
- if (name.size() > 0) {
- if (name[0] == kPseudoHeaderPrefix) {
- if (regular_header_seen_) {
- return false;
- }
- } else {
- regular_header_seen_ = true;
- }
- }
-
if (handler_ == nullptr) {
auto it = decoded_block_.find(name);
if (it == decoded_block_.end()) {
« no previous file with comments | « net/spdy/hpack/hpack_decoder.h ('k') | net/spdy/hpack/hpack_decoder_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698