Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: net/spdy/header_coalescer.h

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lint errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/header_coalescer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/header_coalescer.h
diff --git a/net/spdy/header_coalescer.h b/net/spdy/header_coalescer.h
index ea229f00e6a67cf4357f24ae44575624b2f63453..07cd3889a34f9ea235b81fbe3bc900f414c53adc 100644
--- a/net/spdy/header_coalescer.h
+++ b/net/spdy/header_coalescer.h
@@ -8,12 +8,14 @@
#include "net/base/net_export.h"
#include "net/spdy/spdy_header_block.h"
#include "net/spdy/spdy_headers_handler_interface.h"
+#include "net/spdy/spdy_protocol.h"
namespace net {
class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {
public:
- HeaderCoalescer() {}
+ explicit HeaderCoalescer(const SpdyMajorVersion& protocol_version)
+ : protocol_version_(protocol_version) {}
void OnHeaderBlockStart() override {}
@@ -28,6 +30,8 @@ class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {
SpdyHeaderBlock headers_;
size_t header_list_size_ = 0;
bool error_seen_ = false;
+ bool regular_header_seen_ = false;
+ SpdyMajorVersion protocol_version_;
};
} // namespace net
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/header_coalescer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698