Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: net/spdy/hpack/hpack_decoder.cc

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removes tests and HpackDecoder::regular_header_seen_. Adds header validation into HeaderCoalescer. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/hpack/hpack_decoder.cc
diff --git a/net/spdy/hpack/hpack_decoder.cc b/net/spdy/hpack/hpack_decoder.cc
index e8f3f263915178e6c62a78600d837d5a5aa43ed2..dbf3152efc2303401111f274574c9c1e8b291279 100644
--- a/net/spdy/hpack/hpack_decoder.cc
+++ b/net/spdy/hpack/hpack_decoder.cc
@@ -25,7 +25,6 @@ HpackDecoder::HpackDecoder()
: max_string_literal_size_(kDefaultMaxStringLiteralSize),
handler_(nullptr),
total_header_bytes_(0),
- regular_header_seen_(false),
header_block_started_(false),
total_parsed_bytes_(0) {}
@@ -75,8 +74,6 @@ bool HpackDecoder::HandleControlFrameHeadersData(const char* headers_data,
}
bool HpackDecoder::HandleControlFrameHeadersComplete(size_t* compressed_len) {
- regular_header_seen_ = false;
-
if (compressed_len != nullptr) {
*compressed_len = total_parsed_bytes_;
}
@@ -101,17 +98,6 @@ bool HpackDecoder::HandleHeaderRepresentation(StringPiece name,
StringPiece value) {
total_header_bytes_ += name.size() + value.size();
- // Fail if pseudo-header follows regular header.
- if (name.size() > 0) {
- if (name[0] == kPseudoHeaderPrefix) {
- if (regular_header_seen_) {
- return false;
- }
- } else {
- regular_header_seen_ = true;
- }
- }
-
if (handler_ == nullptr) {
auto it = decoded_block_.find(name);
if (it == decoded_block_.end()) {

Powered by Google App Engine
This is Rietveld 408576698