Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Side by Side Diff: net/spdy/buffered_spdy_framer.cc

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lint errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/spdy/header_coalescer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/buffered_spdy_framer.h" 5 #include "net/spdy/buffered_spdy_framer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 9
10 namespace net { 10 namespace net {
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 void BufferedSpdyFramer::OnStreamEnd(SpdyStreamId stream_id) { 204 void BufferedSpdyFramer::OnStreamEnd(SpdyStreamId stream_id) {
205 visitor_->OnStreamEnd(stream_id); 205 visitor_->OnStreamEnd(stream_id);
206 } 206 }
207 207
208 void BufferedSpdyFramer::OnStreamPadding(SpdyStreamId stream_id, size_t len) { 208 void BufferedSpdyFramer::OnStreamPadding(SpdyStreamId stream_id, size_t len) {
209 visitor_->OnStreamPadding(stream_id, len); 209 visitor_->OnStreamPadding(stream_id, len);
210 } 210 }
211 211
212 SpdyHeadersHandlerInterface* BufferedSpdyFramer::OnHeaderFrameStart( 212 SpdyHeadersHandlerInterface* BufferedSpdyFramer::OnHeaderFrameStart(
213 SpdyStreamId stream_id) { 213 SpdyStreamId stream_id) {
214 coalescer_.reset(new HeaderCoalescer()); 214 coalescer_.reset(new HeaderCoalescer(protocol_version()));
215 return coalescer_.get(); 215 return coalescer_.get();
216 } 216 }
217 217
218 void BufferedSpdyFramer::OnHeaderFrameEnd(SpdyStreamId stream_id, 218 void BufferedSpdyFramer::OnHeaderFrameEnd(SpdyStreamId stream_id,
219 bool end_headers) { 219 bool end_headers) {
220 if (coalescer_->error_seen()) { 220 if (coalescer_->error_seen()) {
221 visitor_->OnStreamError(stream_id, 221 visitor_->OnStreamError(stream_id,
222 "Could not parse Spdy Control Frame Header."); 222 "Could not parse Spdy Control Frame Header.");
223 return; 223 return;
224 } 224 }
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 } 495 }
496 496
497 void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) { 497 void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) {
498 header_buffer_.clear(); 498 header_buffer_.clear();
499 header_buffer_valid_ = true; 499 header_buffer_valid_ = true;
500 header_stream_id_ = stream_id; 500 header_stream_id_ = stream_id;
501 DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream); 501 DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream);
502 } 502 }
503 503
504 } // namespace net 504 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/spdy/header_coalescer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698