Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: net/spdy/header_coalescer.h

Issue 2028473003: Move header-ordering validation from hpack decoder to header validator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removes tests and HpackDecoder::regular_header_seen_. Adds header validation into HeaderCoalescer. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/spdy/header_coalescer.cc » ('j') | net/spdy/header_coalescer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_HEADER_COALESCER_H_ 5 #ifndef NET_SPDY_HEADER_COALESCER_H_
6 #define NET_SPDY_HEADER_COALESCER_H_ 6 #define NET_SPDY_HEADER_COALESCER_H_
7 7
8 #include "net/base/net_export.h" 8 #include "net/base/net_export.h"
9 #include "net/spdy/spdy_header_block.h" 9 #include "net/spdy/spdy_header_block.h"
10 #include "net/spdy/spdy_headers_handler_interface.h" 10 #include "net/spdy/spdy_headers_handler_interface.h"
11 11
12 namespace net { 12 namespace net {
13 13
14 class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface { 14 class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {
15 public: 15 public:
16 HeaderCoalescer() {} 16 HeaderCoalescer() {}
17 17
18 void OnHeaderBlockStart() override {} 18 void OnHeaderBlockStart() override {}
19 19
20 void OnHeader(base::StringPiece key, base::StringPiece value) override; 20 void OnHeader(base::StringPiece key, base::StringPiece value) override;
21 21
22 void OnHeaderBlockEnd(size_t uncompressed_header_bytes) override {} 22 void OnHeaderBlockEnd(size_t uncompressed_header_bytes) override {}
23 23
24 const SpdyHeaderBlock& headers() const { return headers_; } 24 const SpdyHeaderBlock& headers() const { return headers_; }
25 bool error_seen() const { return error_seen_; } 25 bool error_seen() const { return error_seen_; }
26 26
27 private: 27 private:
28 SpdyHeaderBlock headers_; 28 SpdyHeaderBlock headers_;
29 bool error_seen_ = false; 29 bool error_seen_ = false;
30 bool regular_header_seen_ = false;
30 }; 31 };
31 32
32 } // namespace net 33 } // namespace net
33 34
34 #endif // NET_SPDY_HEADER_COALESCER_H_ 35 #endif // NET_SPDY_HEADER_COALESCER_H_
OLDNEW
« no previous file with comments | « no previous file | net/spdy/header_coalescer.cc » ('j') | net/spdy/header_coalescer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698