Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2028473002: Added new icons for user menu (Closed)

Created:
4 years, 6 months ago by Jane
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added two new icons for user menu. See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.abdhimh1kvzb These two icons are to be used for the "Manage people" button as well as the sync error icon displayed on titlebar. See how they will be used here: https://codereview.chromium.org/2019053002/ BUG=615893 Committed: https://crrev.com/a592811157d54d1f0fea98de73323f908a0b289c Cr-Commit-Position: refs/heads/master@{#397422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M ui/gfx/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/settings.icon View 1 chunk +51 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/sync_problem.icon View 1 chunk +39 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (13 generated)
Jane
4 years, 6 months ago (2016-05-30 20:59:37 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm Looks great Jane. There is a bug number now so you can change the ...
4 years, 6 months ago (2016-05-30 21:20:27 UTC) #5
Jane
4 years, 6 months ago (2016-05-30 21:32:06 UTC) #8
Evan Stade
lgtm
4 years, 6 months ago (2016-06-02 00:20:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028473002/1
4 years, 6 months ago (2016-06-02 00:25:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239323)
4 years, 6 months ago (2016-06-02 01:59:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028473002/1
4 years, 6 months ago (2016-06-02 02:07:09 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/223188)
4 years, 6 months ago (2016-06-02 02:54:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028473002/1
4 years, 6 months ago (2016-06-02 14:30:05 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 15:47:53 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 15:49:09 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a592811157d54d1f0fea98de73323f908a0b289c
Cr-Commit-Position: refs/heads/master@{#397422}

Powered by Google App Engine
This is Rietveld 408576698