Chromium Code Reviews Chromium Code Reviews
Issue 2028463002:
Convert media-can-* tests to testharness.js (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html |
| diff --git a/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html b/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html |
| index 0d9912e7572acf79a2fe0147bd3c9856b5282b0b..6c5a3596921679dcc007850ca40c0ad340c3edfd 100644 |
| --- a/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html |
| +++ b/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html |
| @@ -1,26 +1,16 @@ |
| -<html> |
| - <head> |
| - <style> |
| - video {display:none; background-color: yellow; width: 320px; height: 240px;} |
| - </style> |
| - </head> |
| - <body onload="start()"> |
| - |
| - <video controls ></video> |
| - |
| - <p>Test HTMLMediaElement to be sure that the video is getting loaded even if the element |
| - is hidden.</p> |
| - <script src=media-file.js></script> |
| - <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956 |
| - (Please avoid writing new tests using video-test.js) --> |
| - <script src=video-test.js></script> |
| - <script> |
| - function start() |
| - { |
| - video = document.getElementsByTagName('video')[0]; |
| - waitForEvent('durationchange', function() { endTest(); }); |
| - video.src = findMediaFile("video", "content/test"); |
| - } |
| - </script> |
| - </body> |
| -</html> |
| +<!DOCTYPE html> |
| +<title>Test HTMLMediaElement to be sure that the video is getting loaded even if the element is hidden.</title> |
| +<style> |
| + video { display: none; background-color: yellow; width: 320px; height: 240px; } |
|
foolip
2016/05/30 20:18:48
Suggest dropping the other properties, seems point
Srirama
2016/05/31 14:30:55
Done.
|
| +</style> |
| +<video></video> |
| +<script src="media-file.js"></script> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script> |
| +async_test(function(t) { |
| + var video = document.querySelector("video"); |
| + video.ondurationchange = t.step_func_done(); |
| + video.src = findMediaFile("video", "content/test"); |
| +}); |
| +</script> |
