Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2028463002: Convert media-can-* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert media-can-* tests to testharness.js Cleaning up media-can-* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/3537e717b45ba20b348dc20c903ffa47d8a60303 Cr-Commit-Position: refs/heads/master@{#396843}

Patch Set 1 : #

Total comments: 14

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -360 lines) Patch
M third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html View 1 1 chunk +16 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-can-load-when-hidden-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-flac-audio.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-flac-audio-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-mpeg-audio.html View 1 1 chunk +16 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-mpeg-audio-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-mpeg4-video.html View 1 1 chunk +14 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-mpeg4-video-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html View 1 1 chunk +17 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-can-play-octet-stream-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-ogg.html View 1 chunk +16 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-can-play-ogg-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-type.html View 1 chunk +18 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-can-play-type-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-wav-audio.html View 1 chunk +15 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-can-play-wav-audio-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-webm.html View 1 chunk +28 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-can-play-webm-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Srirama
PTAL
4 years, 6 months ago (2016-05-30 18:40:14 UTC) #4
fs
lgtm https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html File third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html (right): https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html#newcode14 third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:14: }, "check \"canPlayType\" method for " + mediaElement); ...
4 years, 6 months ago (2016-05-30 19:54:47 UTC) #5
foolip
lgtm % nits https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html File third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html (right): https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html#newcode4 third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html:4: video { display: none; background-color: yellow; ...
4 years, 6 months ago (2016-05-30 20:18:49 UTC) #6
Srirama
https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html File third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html (right): https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html#newcode4 third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html:4: video { display: none; background-color: yellow; width: 320px; height: ...
4 years, 6 months ago (2016-05-31 14:30:55 UTC) #7
foolip
https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html File third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html (right): https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html#newcode20 third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:20: var audio = new Audio(); On 2016/05/31 14:30:55, Srirama ...
4 years, 6 months ago (2016-05-31 14:44:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028463002/40001
4 years, 6 months ago (2016-05-31 15:20:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-05-31 16:23:44 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 16:25:17 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3537e717b45ba20b348dc20c903ffa47d8a60303
Cr-Commit-Position: refs/heads/master@{#396843}

Powered by Google App Engine
This is Rietveld 408576698