Convert media-can-* tests to testharness.js

Convert media-can-* tests to testharness.js

Cleaning up media-can-* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/3537e717b45ba20b348dc20c903ffa47d8a60303
Cr-Commit-Position: refs/heads/master@{#396843}

[Srirama, 2016-05-30 18:28:58]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert media-can-* tests to testharness.js

Cleaning up media-can-* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-05-30 18:39:42]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-05-30 18:40:14]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-05-30 18:40:14]

PTAL

[fs, 2016-05-30 19:54:47]

lgtm

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:14: },
"check \"canPlayType\" method for " + mediaElement);
Nit: Maybe mediaElement.tagName?

[foolip, 2016-05-30 20:18:49]

lgtm % nits

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html:4: video {
display: none; background-color: yellow; width: 320px; height: 240px; }
Suggest dropping the other properties, seems pointless.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-flac-audio-expected.txt
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-flac-audio-expected.txt:2:
FAIL Test HTMLMediaElement's "canPlayType" method with multiple .flac MIME
types. assert_equals: expected "maybe" but got ""
This seems kind of pointless. I don't expect the status of FLAC will ever
change, so better to just test for the lack of support or remove the test
entirely.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-mpeg-audio-expected.txt
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-mpeg-audio-expected.txt:2:
FAIL Test HTMLMediaElement's "canPlayType()" method with multiple audio mpeg
MIME types. assert_equals: expected "maybe" but got ""
This isn't great, previously any change in support would fail the test, now as
long as the first failure is the same the test will change. If the result is the
same on all platforms, can you make the test just pass instead?

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/media-can-play-mpeg4-video-expected.txt
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-mpeg4-video-expected.txt:2:
FAIL Test HTMLMediaElement's "canPlayType()" method with multiple video mpeg4
MIME types. assert_equals: expected "maybe" but got ""
Ditto

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:14: },
"check \"canPlayType\" method for " + mediaElement);
On 2016/05/30 19:54:47, fs wrote:
> Nit: Maybe mediaElement.tagName?

Or localName to get it it lower case

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:20: var
audio = new Audio();
Seems kinda weird to have one in markup and create the other. How about just
passing the tagName as the argument and creating the element inside the
test(function() { ... })?

[Srirama, 2016-05-31 14:30:55]

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-load-when-hidden.html:4: video {
display: none; background-color: yellow; width: 320px; height: 240px; }
On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> Suggest dropping the other properties, seems pointless.

Done.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-flac-audio-expected.txt
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-flac-audio-expected.txt:2:
FAIL Test HTMLMediaElement's "canPlayType" method with multiple .flac MIME
types. assert_equals: expected "maybe" but got ""
On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> This seems kind of pointless. I don't expect the status of FLAC will ever
> change, so better to just test for the lack of support or remove the test
> entirely.

Done.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-mpeg-audio-expected.txt
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-mpeg-audio-expected.txt:2:
FAIL Test HTMLMediaElement's "canPlayType()" method with multiple audio mpeg
MIME types. assert_equals: expected "maybe" but got ""
On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> This isn't great, previously any change in support would fail the test, now as
> long as the first failure is the same the test will change. If the result is
the
> same on all platforms, can you make the test just pass instead?

Done.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/media-can-play-mpeg4-video-expected.txt
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-mpeg4-video-expected.txt:2:
FAIL Test HTMLMediaElement's "canPlayType()" method with multiple video mpeg4
MIME types. assert_equals: expected "maybe" but got ""
On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> Ditto

Done.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:14: },
"check \"canPlayType\" method for " + mediaElement);
On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> On 2016/05/30 19:54:47, fs wrote:
> > Nit: Maybe mediaElement.tagName?
> 
> Or localName to get it it lower case

Done.

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:20: var
audio = new Audio();
On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> Seems kinda weird to have one in markup and create the other. How about just
> passing the tagName as the argument and creating the element inside the
> test(function() { ... })?

Done. I thought probably they want to test one with tagname and one with JS
constructor.

[foolip, 2016-05-31 14:44:08]

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html
(right):

https://codereview.chromium.org/2028463002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-can-play-octet-stream.html:20: var
audio = new Audio();
On 2016/05/31 14:30:55, Srirama wrote:
> On 2016/05/30 20:18:48, Philip Jägenstedt wrote:
> > Seems kinda weird to have one in markup and create the other. How about just
> > passing the tagName as the argument and creating the element inside the
> > test(function() { ... })?
> 
> Done. I thought probably they want to test one with tagname and one with JS
> constructor.

Maybe that was the idea, but there are plenty of test relying on the Audio
constructor and it should not matter, so thanks for making the test cleaner! :)

[Srirama, 2016-05-31 15:20:01]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-05-31 15:20:02]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2028463002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-31 15:20:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028463002/40001

[commit-bot: I haz the power, 2016-05-31 16:23:43]

Description was changed from

==========
Convert media-can-* tests to testharness.js

Cleaning up media-can-* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert media-can-* tests to testharness.js

Cleaning up media-can-* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-05-31 16:23:44]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-31 16:25:15]

Description was changed from

==========
Convert media-can-* tests to testharness.js

Cleaning up media-can-* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert media-can-* tests to testharness.js

Cleaning up media-can-* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/3537e717b45ba20b348dc20c903ffa47d8a60303
Cr-Commit-Position: refs/heads/master@{#396843}
==========

[commit-bot: I haz the power, 2016-05-31 16:25:17]

Patchset 2 (id:??) landed as
https://crrev.com/3537e717b45ba20b348dc20c903ffa47d8a60303
Cr-Commit-Position: refs/heads/master@{#396843}