Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2028443002: exo: Implement lazy cursor changes. (Closed)

Created:
4 years, 6 months ago by reveman
Modified:
4 years, 6 months ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Implement lazy cursor changes. Pointer::SetCursor() is now required to be called in response to focus change events. This provides more seamless cursor changes as the cursor will remain the same until it has been re-defined. Simply clients that never define the cursor will now get the default cursor instead of no cursor at all. Clients that draw their own cursor now have a chance to provide a new frame before the cursor is changed. BUG=549781 Committed: https://crrev.com/70baca1c3bcf3ac902f4313da5e74b2592f85fb4 Cr-Commit-Position: refs/heads/master@{#396919}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -5 lines) Patch
M components/exo/pointer.cc View 4 chunks +21 lines, -4 lines 0 comments Download
M components/exo/surface.h View 4 chunks +17 lines, -0 lines 0 comments Download
M components/exo/surface.cc View 2 chunks +16 lines, -1 line 1 comment Download

Messages

Total messages: 11 (6 generated)
reveman
4 years, 6 months ago (2016-05-30 17:42:33 UTC) #2
Daniele Castagna
nit: in the CL description "Clients [...] now has" LGTM. https://codereview.chromium.org/2028443002/diff/1/components/exo/surface.cc File components/exo/surface.cc (right): https://codereview.chromium.org/2028443002/diff/1/components/exo/surface.cc#newcode84 ...
4 years, 6 months ago (2016-05-31 19:32:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028443002/1
4 years, 6 months ago (2016-05-31 19:48:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:35:51 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:45:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70baca1c3bcf3ac902f4313da5e74b2592f85fb4
Cr-Commit-Position: refs/heads/master@{#396919}

Powered by Google App Engine
This is Rietveld 408576698