Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issue 2028433003: Revert of Allow CrossThreadPersistent in collections (Closed)

Created:
4 years, 3 months ago by keishi
Modified:
4 years, 3 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow CrossThreadPersistent in collections (patchset #7 id:120001 of https://codereview.chromium.org/2007283002/ ) Reason for revert: blink_perf.bindings regression on android.webview crbug.com/615832 Original issue's description: > Allow CrossThreadPersistent in collections > > BUG=591606 > > Committed: https://crrev.com/5adc4454691bffcbfdc7cd60866c145a4e67de0d > Cr-Commit-Position: refs/heads/master@{#396410} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591606 Committed: https://crrev.com/687a70a8ab0b0cfdd17f8d57d639d9b0ad7cd1c9 Cr-Commit-Position: refs/heads/master@{#396772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -306 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 5 chunks +53 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +0 lines, -238 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 6 chunks +2 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
keishi
Created Revert of Allow CrossThreadPersistent in collections
4 years, 3 months ago (2016-05-31 01:22:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028433003/1
4 years, 3 months ago (2016-05-31 01:22:18 UTC) #3
haraken
LGTM
4 years, 3 months ago (2016-05-31 01:23:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 02:57:46 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 02:59:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/687a70a8ab0b0cfdd17f8d57d639d9b0ad7cd1c9
Cr-Commit-Position: refs/heads/master@{#396772}

Powered by Google App Engine
This is Rietveld 408576698