Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 2028383006: Add GN configs for -fsanitizer=null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Compile for Address Sanitizer to find memory bugs. 6 # Compile for Address Sanitizer to find memory bugs.
7 is_asan = false 7 is_asan = false
8 8
9 # Compile for Leak Sanitizer to find leaks. 9 # Compile for Leak Sanitizer to find leaks.
10 is_lsan = false 10 is_lsan = false
11 11
12 # Compile for Memory Sanitizer to find uninitialized reads. 12 # Compile for Memory Sanitizer to find uninitialized reads.
13 is_msan = false 13 is_msan = false
14 14
15 # Compile for Thread Sanitizer to find threading bugs. 15 # Compile for Thread Sanitizer to find threading bugs.
16 is_tsan = false 16 is_tsan = false
17 17
18 # Compile for Undefined Behaviour Sanitizer to find various types of 18 # Compile for Undefined Behaviour Sanitizer to find various types of
19 # undefined behaviour (excludes vptr checks). 19 # undefined behaviour (excludes vptr checks).
20 is_ubsan = false 20 is_ubsan = false
21 21
22 # Halt the program if a problem is detected. 22 # Halt the program if a problem is detected.
23 is_ubsan_no_recover = false 23 is_ubsan_no_recover = false
24 24
25 # Compile for Undefined Behaviour Sanitizer's null pointer checks.
26 is_ubsan_null = false
27
25 # Compile for Undefined Behaviour Sanitizer's vptr checks. 28 # Compile for Undefined Behaviour Sanitizer's vptr checks.
26 is_ubsan_vptr = false 29 is_ubsan_vptr = false
27 30
28 # Track where uninitialized memory originates from. From fastest to slowest: 31 # Track where uninitialized memory originates from. From fastest to slowest:
29 # 0 - no tracking, 1 - track only the initial allocation site, 2 - track the 32 # 0 - no tracking, 1 - track only the initial allocation site, 2 - track the
30 # chain of stores leading from allocation site to use site. 33 # chain of stores leading from allocation site to use site.
31 msan_track_origins = 2 34 msan_track_origins = 2
32 35
33 # Use dynamic libraries instrumented by one of the sanitizers instead of the 36 # Use dynamic libraries instrumented by one of the sanitizers instead of the
34 # standard system libraries. Set this flag to download prebuilt binaries from 37 # standard system libraries. Set this flag to download prebuilt binaries from
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 88
86 # Enable -fsanitize-coverage. 89 # Enable -fsanitize-coverage.
87 use_sanitizer_coverage = use_libfuzzer || sanitizer_coverage_flags != "" 90 use_sanitizer_coverage = use_libfuzzer || sanitizer_coverage_flags != ""
88 } 91 }
89 92
90 if (use_sanitizer_coverage && sanitizer_coverage_flags == "") { 93 if (use_sanitizer_coverage && sanitizer_coverage_flags == "") {
91 sanitizer_coverage_flags = "edge,indirect-calls,8bit-counters" 94 sanitizer_coverage_flags = "edge,indirect-calls,8bit-counters"
92 } 95 }
93 96
94 using_sanitizer = is_asan || is_lsan || is_tsan || is_msan || is_ubsan || 97 using_sanitizer = is_asan || is_lsan || is_tsan || is_msan || is_ubsan ||
95 is_ubsan_vptr || is_ubsan_security 98 is_ubsan_null || is_ubsan_vptr || is_ubsan_security
96 99
97 assert(!using_sanitizer || is_clang, 100 assert(!using_sanitizer || is_clang,
98 "Sanitizers (is_*san) require setting is_clang = true in 'gn args'") 101 "Sanitizers (is_*san) require setting is_clang = true in 'gn args'")
99 102
100 # MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The 103 # MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The
101 # same is possibly true for the other non-ASan sanitizers. But regardless of 104 # same is possibly true for the other non-ASan sanitizers. But regardless of
102 # whether it links, one would normally never run a sanitizer in debug mode. 105 # whether it links, one would normally never run a sanitizer in debug mode.
103 # Running in debug mode probably indicates you forgot to set the "is_debug = 106 # Running in debug mode probably indicates you forgot to set the "is_debug =
104 # false" flag in the build args. ASan seems to run fine in debug mode. 107 # false" flag in the build args. ASan seems to run fine in debug mode.
105 # 108 #
106 # If you find a use-case where you want to compile a sanitizer in debug mode 109 # If you find a use-case where you want to compile a sanitizer in debug mode
107 # and have verified it works, ask brettw and we can consider removing it from 110 # and have verified it works, ask brettw and we can consider removing it from
108 # this condition. We may also be able to find another way to enable your case 111 # this condition. We may also be able to find another way to enable your case
109 # without having people accidentally get broken builds by compiling an 112 # without having people accidentally get broken builds by compiling an
110 # unsupported or unadvisable configurations. 113 # unsupported or unadvisable configurations.
111 # 114 #
112 # For one-off testing, just comment this assertion out. 115 # For one-off testing, just comment this assertion out.
113 assert( 116 assert(!is_debug || !(is_msan || is_lsan || is_tsan || is_ubsan ||
114 !is_debug || !(is_msan || is_lsan || is_tsan || is_ubsan || is_ubsan_vptr), 117 is_ubsan_null || is_ubsan_vptr),
115 "Sanitizers should generally be used in release (set is_debug=false).") 118 "Sanitizers should generally be used in release (set is_debug=false).")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698