Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2028363002: IntersectionObserver: make order of notifications deterministic. (Closed)

Created:
4 years, 6 months ago by szager1
Modified:
4 years, 6 months ago
Reviewers:
eae, ojan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: make order of notifications deterministic. The order of IntersectionObserverEntry objects sent to the callback should be ordered by 1) time, and 2) order in which the target elements were observe()'ed. BUG=613679 R=ojan@chromium.org,eae@chromium.org Committed: https://crrev.com/b69c620b66c4953805cb94cd87ebf057e43add17 Cr-Commit-Position: refs/heads/master@{#397317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/intersection-observer/multiple-targets.html View 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/intersection-observer/multiple-targets-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
szager1
4 years, 6 months ago (2016-06-01 22:27:28 UTC) #1
eae
LGTM
4 years, 6 months ago (2016-06-01 22:38:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028363002/1
4 years, 6 months ago (2016-06-01 22:40:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239109)
4 years, 6 months ago (2016-06-02 02:12:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028363002/1
4 years, 6 months ago (2016-06-02 02:45:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239523)
4 years, 6 months ago (2016-06-02 03:30:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028363002/1
4 years, 6 months ago (2016-06-02 05:40:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:41:06 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:42:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b69c620b66c4953805cb94cd87ebf057e43add17
Cr-Commit-Position: refs/heads/master@{#397317}

Powered by Google App Engine
This is Rietveld 408576698