Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 FROM ubuntu:trusty | 1 FROM ubuntu:trusty |
| 2 | 2 |
| 3 # Run the command below to update the lib list. | 3 # Run the command below to update the lib list. |
| 4 # ldd ./blimp_engine_app | grep usr/lib | awk '{print $3}' | xargs -n1 \ | 4 # ldd ./blimp_engine_app | grep usr/lib | awk '{print $3}' | xargs -n1 \ |
| 5 # dpkg-query -S | awk -F: '{print $1}' | sort | uniq | 5 # dpkg-query -S | awk -F: '{print $1}' | sort | uniq |
| 6 RUN apt-get update && \ | 6 RUN apt-get update && \ |
|
maniscalco
2016/06/02 19:15:55
Let's talk about the Dockerfile OOB. It would be
Sriram
2016/06/02 19:55:05
+1
Jess
2016/06/02 23:02:14
I intended this Dockerfile as a stub that would ne
| |
| 7 apt-get install -yq libdrm2 libfontconfig1 libfreetype6 libgraphite2-3 \ | 7 apt-get install -yq libdrm2 libfontconfig1 libfreetype6 libgraphite2-3 \ |
| 8 libharfbuzz0b libnspr4 libnss3 libstdc++6 | 8 libharfbuzz0b libnspr4 libnss3 libstdc++6 |
| 9 | 9 |
| 10 RUN apt-get update && apt-get install -yq stunnel4 wget | 10 RUN apt-get update && apt-get install -yq stunnel4 wget |
| 11 | 11 |
| 12 RUN mkdir /engine | 12 RUN mkdir /out |
| 13 RUN mkdir /out/test | |
|
Sriram
2016/06/02 19:55:05
could use "mkdir -p" to create all parents as well
Jess
2016/06/02 23:02:14
Done.
Mostly because I structured this based on h
| |
| 13 | 14 |
| 14 RUN useradd -ms /bin/bash blimp_user | 15 RUN useradd -ms /bin/bash blimp_user |
| 15 | 16 |
| 16 # The glob below expands to all files, but does not add directories | 17 # The glob below expands to all files, but does not add directories |
| 17 # recursively. | 18 # recursively. |
| 18 ADD * /engine/ | 19 ADD * /out/test/ |
| 19 ADD gen/third_party/blimp_fonts /engine/fonts | 20 RUN chown -R blimp_user /out/test |
| 20 RUN mv /engine/chrome_sandbox /engine/chrome-sandbox | |
| 21 RUN chown -R blimp_user /engine | |
| 22 | 21 |
| 23 USER blimp_user | 22 USER blimp_user |
| 24 WORKDIR "/engine" | 23 WORKDIR "/out/test" |
| 25 | |
| 26 ENTRYPOINT ["/engine/start_engine.sh"] | |
| OLD | NEW |