Support for bundling Chromium unittests into a tarball.

blimp/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 # Convenience meta-target for all of Blimp's production & test code.
 group("blimp") {
@@ skipping 120 matching lines @@
 
     # By specifying a dependency (not a data_dependency) on :blimp_tests_group,
     # we can be sure that everything is built before the action is
     # complete (though not necessarily before we generate the manifest
     # itself).
     deps = [
       ":blimp_engine_env_tests_group",
     ]
   }
 }
+
+# Builds and bundles the tests into a tarball that can be used to build a
+# Docker image.
+action("blimp_engine_env_tests_bundle") {
+  testonly = true
+  script = "//blimp/tools/bundle.py"
+
+  # These form the arguments to the script.
+  _rebased_out_dir = rebase_path(root_out_dir)
+  _rebased_dockerfile = rebase_path("//blimp/Dockerfile")
+  _bundle = "$root_out_dir/blimp_engine_env_tests_bundle.tar.gz"
+
+  # Depending on this ensures that both the manifest is generated
+  # and everything in the manifest has been built.
+  deps = [
+    ":generate_blimp_engine_env_tests_manifest",
+  ]
+
+  sources = [
+    _blimp_engine_env_tests_manifest,

[Sriram, 2016/06/02 19:55:05]

Should this be _rebased_blimp_engine_env_tests_manifest? It is not clear as when
one would use rebased version vs not.

[Jess, 2016/06/02 23:02:14]

Nope. That will fail to build.

The issue is that rebasing is being used to set arguments to both the root and
gen dir. The naming convention I copied from engine bundling tracks if a rebase
occurred rather than which root directory a file is part of. That code should
probably be refactored too, but it might be best to tackle that in a stand alone
codereview.

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/languag...

+    _rebased_dockerfile,
+  ]
+  outputs = [
+    _bundle,
+  ]
+
+  # Manually specify the actual arguments to the script.
+  args = [
+    "--build-dir",
+    _rebased_out_dir,
+    "--dockerfile",
+    _rebased_dockerfile,
+    "--manifest",
+    _rebased_blimp_engine_env_tests_manifest,
+    "--output",
+    rebase_path(_bundle),
+  ]
+}