Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2028343002: Don't use array for only one compatible mode script (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Don't use array for only one compatible mode script Also, don't invent an enum that has one possible value that is always set. Committed: https://pdfium.googlesource.com/pdfium/+/fb2a824f87f7096382681fd258906823ef93ebec

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -45 lines) Patch
M xfa/fxfa/parser/xfa_script_imp.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fxjse/context.cpp View 2 chunks +33 lines, -33 lines 1 comment Download
M xfa/fxjse/include/fxjse.h View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/2028343002/diff/1/xfa/fxjse/context.cpp File xfa/fxjse/context.cpp (right): https://codereview.chromium.org/2028343002/diff/1/xfa/fxjse/context.cpp#newcode15 xfa/fxjse/context.cpp:15: const FX_CHAR szCompatibleModeScript[] = note: not ...
4 years, 6 months ago (2016-06-01 22:05:50 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-01 22:53:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028343002/1
4 years, 6 months ago (2016-06-01 22:59:07 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 23:10:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fb2a824f87f7096382681fd258906823ef93...

Powered by Google App Engine
This is Rietveld 408576698