Refactor git_footers for later use in git cl.

tests/git_footers_test.py

Index: tests/git_footers_test.py
diff --git a/tests/git_footers_test.py b/tests/git_footers_test.py
index 23ca473637f883f10360567db721caee6fca6214..c4215bb1b64ea569b7b7c914574c2ab93c81291b 100755
--- a/tests/git_footers_test.py
+++ b/tests/git_footers_test.py
@@ -35,9 +35,15 @@ My commit message is my best friend. It is my life. I must master it.
 
   _git_svn_id_footer_branch = 'git-svn-id: %s\n' % _git_svn_id_branch
 
-
   def testFootersBasic(self):
     self.assertEqual(
+        git_footers.split_footers('Not-A: footer'),
+        (['Not-A: footer'], [], []))
+    self.assertEqual(
+        git_footers.split_footers('Header\n\nActual: footer'),
+        (['Header', ''], ['Actual: footer'], [('Actual', 'footer')]))

[Sergiy Byelozyorov, 2016/06/02 23:16:27]

also add

self.assertEqual(git_footers.split_footers('\nActual: footer'), ([''], ['Actual:
footer'], [('Actual', 'footer')]))

[tandrii(chromium), 2016/06/03 09:16:17]

good idea.

+
+    self.assertEqual(
         git_footers.parse_footers(self._message), {})
     self.assertEqual(
         git_footers.parse_footers(self._message + self._position_footer),
@@ -82,6 +88,9 @@ My commit message is my best friend. It is my life. I must master it.
         'desc\nBUG=not-a-valid-footer\n\nChange-Id: Ixxx'))
 
   def testAddFooterChangeId(self):
+    with self.assertRaises(AssertionError):
+      git_footers.add_footer_change_id('Already has\n\nChange-Id: Ixxx', 'Izzz')
+
     self.assertEqual(
         git_footers.add_footer_change_id('header-only', 'Ixxx'),
         'header-only\n\nChange-Id: Ixxx')
@@ -107,6 +116,22 @@ My commit message is my best friend. It is my life. I must master it.
         git_footers.add_footer_change_id('header: like footer', 'Ixxx'),
         'header: like footer\n\nChange-Id: Ixxx')
 
+  def testAddFooter(self):
+    self.assertEqual(
+        git_footers.add_footer('', 'Key', 'Value'),
+        '\n\nKey: Value')
+    self.assertEqual(
+        git_footers.add_footer('Top\n\nSome: footer', 'Key', 'value'),
+        'Top\n\nSome: footer\nKey: value')
+    self.assertEqual(
+        git_footers.add_footer('Top\n\nSome: footer', 'Key', 'value',
+                               after_keys=['Any']),
+        'Top\n\nKey: value\nSome: footer')
+    self.assertEqual(
+        git_footers.add_footer('Top\n\nSome: footer', 'Key', 'value',
+                               after_keys=['Some']),
+        'Top\n\nSome: footer\nKey: value')

[Sergiy Byelozyorov, 2016/06/02 23:16:27]

I would also add a test when the footer must be added somewhere in the middle,
e.g.

     self.assertEqual(
         git_footers.add_footer('Top\n\nSome: footer\nOther: footer',
                                'Key', 'value', after_keys=['Some']),
         'Top\n\nSome: footer\nKey: value\nOther: footer')

[tandrii(chromium), 2016/06/03 09:16:17]

excellent!

+
   def testReadStdin(self):
     self.mock(git_footers.sys, 'stdin', StringIO.StringIO(
         'line\r\notherline\r\n\r\n\r\nFoo: baz'))