Hide hover effect on hidden ink drop host views.

ui/views/animation/ink_drop_host_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/animation/ink_drop_host_view.h"
 
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/views/animation/ink_drop.h"
 #include "ui/views/animation/ink_drop_hover.h"
@@ skipping 54 matching lines @@
 }
 
 std::unique_ptr<InkDropHover> InkDropHostView::CreateInkDropHover() const {
   std::unique_ptr<InkDropHover> hover(
       new InkDropHover(ink_drop_size_, kInkDropSmallCornerRadius,
                        GetInkDropCenter(), GetInkDropBaseColor()));
   hover->set_explode_size(CalculateLargeInkDropSize(ink_drop_size_));
   return hover;
 }
 
+void InkDropHostView::VisibilityChanged(View* starting_from, bool is_visible) {
+  View::VisibilityChanged(starting_from, is_visible);
+  if (ink_drop_delegate() && GetWidget() && !is_visible)

[sky, 2016/06/02 03:07:26]

Why do you care if there is a widget here?

[Evan Stade, 2016/06/02 19:34:07]

Without this check it crashes in GetInkDropBaseColor (which tries to use
GetNativeTheme, which doesn't exist if not yet added to a widget hierarchy). 

+    ink_drop_delegate()->GetInkDrop()->SetHovered(false);

[Evan Stade, 2016/06/01 22:46:20]

analogous to CustomButton::VisibilityChanged

[bruthig, 2016/06/02 19:02:59]

Is OnBlur() and more importantly SetFocused(false) going to be called when
InkDropHostViews become invisible?  If not we may want to add that here as well.

[Evan Stade, 2016/06/02 19:34:07]

I didn't investigate with extreme thoroughness but I found that that call was
not necessary to fix the given bug. I would imagine it's because of this line
where focus is advanced when visibility is set to false:

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/view.cc&r...

[bruthig, 2016/06/02 19:46:36]

Awesome, might be worth a test by a good Samaritan at some point.

+}
+
 void InkDropHostView::OnFocus() {
   views::View::OnFocus();
   if (ink_drop_delegate() && ShouldShowInkDropForFocus())
     ink_drop_delegate()->GetInkDrop()->SetFocused(true);
 }
 
 void InkDropHostView::OnBlur() {
   views::View::OnBlur();
   if (ink_drop_delegate() && ShouldShowInkDropForFocus())
     ink_drop_delegate()->GetInkDrop()->SetFocused(false);
 }
 
 gfx::Point InkDropHostView::GetInkDropCenter() const {
   return GetLocalBounds().CenterPoint();
 }
 
 SkColor InkDropHostView::GetInkDropBaseColor() const {
   NOTREACHED();
   return gfx::kPlaceholderColor;
 }
 
 bool InkDropHostView::ShouldShowInkDropForFocus() const {
   return false;
 }
 
 }  // namespace views