Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20283002: Don't duplicate OS::ActivationFrameAlignment() for every POSIX platform. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Don't duplicate OS::ActivationFrameAlignment() for every POSIX platform. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15876

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 2

Patch Set 3 : Addressed comment #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -47 lines) Patch
M src/platform-cygwin.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/platform-openbsd.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/platform-posix.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-25 09:24:51 UTC) #1
Sven Panne
https://codereview.chromium.org/20283002/diff/9/src/platform-solaris.cc File src/platform-solaris.cc (left): https://codereview.chromium.org/20283002/diff/9/src/platform-solaris.cc#oldcode89 src/platform-solaris.cc:89: return Max(STACK_ALIGN, 16); Hmmm, this is missing in the ...
7 years, 5 months ago (2013-07-25 09:35:18 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/20283002/diff/9/src/platform-solaris.cc File src/platform-solaris.cc (left): https://codereview.chromium.org/20283002/diff/9/src/platform-solaris.cc#oldcode89 src/platform-solaris.cc:89: return Max(STACK_ALIGN, 16); On 2013/07/25 09:35:18, Sven Panne wrote: ...
7 years, 5 months ago (2013-07-25 09:42:13 UTC) #3
Sven Panne
lgtm
7 years, 5 months ago (2013-07-25 09:48:05 UTC) #4
Benedikt Meurer
7 years, 5 months ago (2013-07-25 09:49:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r15876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698