Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2028263003:
Offline Pages: Remove leftover file if MHTML generation error occurred. (Closed)
|
Created:
4 years, 6 months ago by dewittj Modified:
4 years, 6 months ago Reviewers:
Dmitry Titov CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOffline Pages: Remove leftover file if MHTML generation error occurred.
BUG=613761
Committed: https://crrev.com/6371c94cacd728df04581e8c300f51c5e49ab6f0
Cr-Commit-Position: refs/heads/master@{#397726}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Update the post task method. #Patch Set 3 : Format. #Messages
Total messages: 17 (6 generated)
dewittj@chromium.org changed reviewers: + fgorski@chromium.org
PTAL
dimich@chromium.org changed reviewers: + dimich@chromium.org - fgorski@chromium.org
I can do it instead of Filip... https://codereview.chromium.org/2028263003/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc (right): https://codereview.chromium.org/2028263003/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc:39: content::BrowserThread::GetBlockingPool()); Isn't it what BrowserThread::FILE is for?
https://codereview.chromium.org/2028263003/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc (right): https://codereview.chromium.org/2028263003/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc:39: content::BrowserThread::GetBlockingPool()); On 2016/06/02 00:03:55, Dmitry Titov wrote: > Isn't it what BrowserThread::FILE is for? Done.
On 2016/06/02 18:05:38, dewittj wrote: > https://codereview.chromium.org/2028263003/diff/1/chrome/browser/android/offl... > File chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc > (right): > > https://codereview.chromium.org/2028263003/diff/1/chrome/browser/android/offl... > chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc:39: > content::BrowserThread::GetBlockingPool()); > On 2016/06/02 00:03:55, Dmitry Titov wrote: > > Isn't it what BrowserThread::FILE is for? > > Done. Thanks, Dmitry!
lgtm Could you file a bug for us to add UMA on 'abandoned files in cache folder', which we can add as part of consistency check that Yafei (I think) is going to work on?
The CQ bit was checked by dewittj@chromium.org
On 2016/06/02 18:42:20, Dmitry Titov wrote: > lgtm > > Could you file a bug for us to add UMA on 'abandoned files in cache folder', > which we can add as part of consistency check that Yafei (I think) is going to > work on? I will repurpose the existing bug.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028263003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dewittj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028263003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Offline Pages: Remove leftover file if MHTML generation error occurred. BUG=613761 ========== to ========== Offline Pages: Remove leftover file if MHTML generation error occurred. BUG=613761 Committed: https://crrev.com/6371c94cacd728df04581e8c300f51c5e49ab6f0 Cr-Commit-Position: refs/heads/master@{#397726} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6371c94cacd728df04581e8c300f51c5e49ab6f0 Cr-Commit-Position: refs/heads/master@{#397726} |
