[crankshaft] Reland "Only exclude explicit 'arguments' (and 'this') from liveness analysis."

[crankshaft] Reland "Only exclude explicit 'arguments' (and 'this') from liveness analysis."

Reland of https://codereview.chromium.org/2026173003 (reverted by
https://codereview.chromium.org/2029563002).

Additionally, we need to record environment markers even for the
case of a.length, where a is aliased arguments (which crankshaft
optimizes to constant for the inlined case or to HArgumentsLength
when not inlined).

BUG=chromium:612146
Committed: https://crrev.com/0d4c526a1dff8747838fe4269ab23522499a89fc
Cr-Commit-Position: refs/heads/master@{#36662}

[Jarin, 2016-06-01 20:02:27]

jarin@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jarin, 2016-06-01 20:02:27]

Could you take a look, please?

As you suspected, there was a problem with the fix - we were not emitting
environment markers for optimized (possibly_aliased_)arguments.length, and this
was picked up by the deopt fuzzer.

This CL introduces the environment marker (in a bit roundabout way, but
consistently with the arguments element access below).

[Benedikt Meurer, 2016-06-02 04:22:08]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-06-02 04:22:08]

lgtm

[Jarin, 2016-06-02 04:23:32]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-06-02 04:23:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028243002/20001

[commit-bot: I haz the power, 2016-06-02 04:28:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-02 04:30:42]

Description was changed from

==========
[crankshaft] Reland "Only exclude explicit 'arguments' (and 'this') from
liveness analysis."

Reland of https://codereview.chromium.org/2026173003 (reverted by
https://codereview.chromium.org/2029563002).

Additionally, we need to record environment markers even for the
case of a.length, where a is aliased arguments (which crankshaft
optimizes to constant for the inlined case or to HArgumentsLength
when not inlined).

BUG=chromium:612146
==========

to

==========
[crankshaft] Reland "Only exclude explicit 'arguments' (and 'this') from
liveness analysis."

Reland of https://codereview.chromium.org/2026173003 (reverted by
https://codereview.chromium.org/2029563002).

Additionally, we need to record environment markers even for the
case of a.length, where a is aliased arguments (which crankshaft
optimizes to constant for the inlined case or to HArgumentsLength
when not inlined).

BUG=chromium:612146

Committed: https://crrev.com/0d4c526a1dff8747838fe4269ab23522499a89fc
Cr-Commit-Position: refs/heads/master@{#36662}
==========

[commit-bot: I haz the power, 2016-06-02 04:30:43]

Patchset 2 (id:??) landed as
https://crrev.com/0d4c526a1dff8747838fe4269ab23522499a89fc
Cr-Commit-Position: refs/heads/master@{#36662}

[Jakob Kummerow, 2016-06-02 08:49:52]

ACK, LGTM.