Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2028223002: Remove base_i18n dependency from cronet_static_tmpl (Closed)

Created:
4 years, 6 months ago by mgersh
Modified:
4 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base_i18n dependency from cronet_static_tmpl cronet_static will still include it depending on build flags. BUG=596506 Committed: https://crrev.com/f3e57315382f03347700b7f575547b42ff0d4f0f Cr-Commit-Position: refs/heads/master@{#397261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/cronet_library_loader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mgersh
PTAL
4 years, 6 months ago (2016-06-01 20:03:01 UTC) #3
xunjieli
On 2016/06/01 20:03:01, mgersh wrote: > PTAL Awesome work! LGTM.
4 years, 6 months ago (2016-06-01 20:18:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028223002/1
4 years, 6 months ago (2016-06-01 20:19:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 21:55:16 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3e57315382f03347700b7f575547b42ff0d4f0f Cr-Commit-Position: refs/heads/master@{#397261}
4 years, 6 months ago (2016-06-01 21:58:08 UTC) #10
xunjieli
4 years, 6 months ago (2016-06-09 14:46:22 UTC) #11
Message was sent while issue was closed.
+ 1 to Miriam's CL. Looking at our sizes graphs, this really made a very big
difference!

Powered by Google App Engine
This is Rietveld 408576698