tcmalloc_unittest: Use malloc and free directly, instead of tc_malloc and tc_free.

tcmalloc_unittest: Use malloc and free directly, instead of tc_malloc and tc_free.

tcmalloc defines malloc and free as wrappers (or aliases) for tc_malloc
and tc_free, so we can test tcmalloc by using malloc and free directly
instead of tc_malloc and tc_free. This fixes the test in component
builds, where tc_malloc and tc_free are defined in a separate DSO with
hidden visibility (due to https://codereview.chromium.org/2019183002/),
and so will not be visible to tests.

Some compilers (e.g. clang) will specifically recognize and optimize
away calls to malloc and free, which would break these tests, as
they are testing specific behavior of the allocator. Address this by
marking the wrappers for malloc and free as NOINLINE.

BUG=
TBR=primiano@chromium.org

Committed: https://crrev.com/453035e20f3baca9b2c143407a814cd9581775ca
Cr-Commit-Position: refs/heads/master@{#397204}

[pcc1, 2016-06-01 18:13:41]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2016-06-01 18:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028183002/1

[commit-bot: I haz the power, 2016-06-01 19:25:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 19:27:49]

Description was changed from

==========
tcmalloc_unittest: Use malloc and free directly, instead of tc_malloc and
tc_free.

tcmalloc defines malloc and free as wrappers (or aliases) for tc_malloc
and tc_free, so we can test tcmalloc by using malloc and free directly
instead of tc_malloc and tc_free. This fixes the test in component
builds, where tc_malloc and tc_free are defined in a separate DSO with
hidden visibility (due to https://codereview.chromium.org/2019183002/),
and so will not be visible to tests.

Some compilers (e.g. clang) will specifically recognize and optimize
away calls to malloc and free, which would break these tests, as
they are testing specific behavior of the allocator. Address this by
marking the wrappers for malloc and free as NOINLINE.

BUG=
TBR=primiano@chromium.org
==========

to

==========
tcmalloc_unittest: Use malloc and free directly, instead of tc_malloc and
tc_free.

tcmalloc defines malloc and free as wrappers (or aliases) for tc_malloc
and tc_free, so we can test tcmalloc by using malloc and free directly
instead of tc_malloc and tc_free. This fixes the test in component
builds, where tc_malloc and tc_free are defined in a separate DSO with
hidden visibility (due to https://codereview.chromium.org/2019183002/),
and so will not be visible to tests.

Some compilers (e.g. clang) will specifically recognize and optimize
away calls to malloc and free, which would break these tests, as
they are testing specific behavior of the allocator. Address this by
marking the wrappers for malloc and free as NOINLINE.

BUG=
TBR=primiano@chromium.org

Committed: https://crrev.com/453035e20f3baca9b2c143407a814cd9581775ca
Cr-Commit-Position: refs/heads/master@{#397204}
==========

[commit-bot: I haz the power, 2016-06-01 19:27:50]

Patchset 1 (id:??) landed as
https://crrev.com/453035e20f3baca9b2c143407a814cd9581775ca
Cr-Commit-Position: refs/heads/master@{#397204}

[Primiano Tucci (use gerrit), 2016-06-01 20:29:06]

LGTM

https://codereview.chromium.org/2028183002/diff/1/base/allocator/tcmalloc_uni...
File base/allocator/tcmalloc_unittest.cc (right):

https://codereview.chromium.org/2028183002/diff/1/base/allocator/tcmalloc_uni...
base/allocator/tcmalloc_unittest.cc:23: NOINLINE void*
TCMallocDoMallocForTest(size_t size) {
Oh, I would have never thought to this. right.