Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 202813005: Add DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION() macro (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Add DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION() macro Add DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION() macro that generates better type helpers for HTML Elements: - Generates more isHTML*Element() helpers that are consistent with the ones in HTMLElementTypeHelpers.h so that there is no different in behavior / supported arguments. - Supports more efficient isHTML*Element() helpers that take an HTMLElement in argument and thus don't need to check the namespace URI, only the local name. R=esprehn, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169466

Patch Set 1 #

Patch Set 2 : Slight clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -35 lines) Patch
M Source/core/editing/Editor.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableColElement.h View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLUnknownElement.h View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/html/LabelableElement.h View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
This makes the manual isHTML*Element() helpers more consistent (and as efficient) as the ones generated ...
6 years, 9 months ago (2014-03-18 17:22:53 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-18 18:01:59 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-18 18:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/202813005/20001
6 years, 9 months ago (2014-03-18 18:41:13 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 19:50:55 UTC) #5
Message was sent while issue was closed.
Change committed as 169466

Powered by Google App Engine
This is Rietveld 408576698