Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java - Issue 202813004: DevTools: [JsDocValidator] Make sure function receivers agree with @this annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java

Issue 202813004: DevTools: [JsDocValidator] Make sure function receivers agree with @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address misunderstood comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java ('k') | Source/devtools/scripts/jsdoc-validator/tests/golden.dat » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java

index 3b8c300dd79626a03ec90b75721b2ccfa1aa34b8..10803aa7320af3caace0abdd0681ff574127c51f 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java

@@ -101,7 +101,8 @@ public final class ReturnAnnotationChecker extends ContextTrackingChecker {

if (isReturningFunction) {

if (!function.hasReturnAnnotation() && isApiFunction) {

- getContext().reportErrorInNode(functionNameNode, 0,

+ reportErrorAtNodeStart(

+ functionNameNode,

"@return annotation is required for API functions that return value");

}

} else {

@@ -110,7 +111,7 @@ public final class ReturnAnnotationChecker extends ContextTrackingChecker {

if (function.hasReturnAnnotation()

&& !isInterfaceFunction

&& !throwingFunctions.contains(function)) {

- getContext().reportErrorInNode(functionNameNode, 0,

+ reportErrorAtNodeStart(functionNameNode,

"@return annotation found, yet function does not return value");

}