Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java

Issue 202813004: DevTools: [JsDocValidator] Make sure function receivers agree with @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address misunderstood comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
index e930753e756c595a39c5cb44173d26b6c2f51aff..e5c52ff4f98a076bfe7ee3ad45405462bcc4e778 100644
--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
@@ -7,6 +7,8 @@ import com.google.javascript.rhino.head.ast.Comment;
import com.google.javascript.rhino.head.ast.FunctionNode;
import com.google.javascript.rhino.head.ast.ObjectProperty;
+import org.chromium.devtools.jsdoc.ValidatorContext;
+
public class AstUtil {
private static final String PROTOTYPE_SUFFIX = ".prototype";
@@ -88,5 +90,10 @@ public class AstUtil {
return null;
}
+ static boolean hasThisAnnotation(FunctionNode node, ValidatorContext context) {
+ Comment comment = AstUtil.getJsDocNode(node);
+ return comment != null && context.getNodeText(comment).contains("@this");
+ }
+
private AstUtil() {}
}

Powered by Google App Engine
This is Rietveld 408576698