Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 202813004: DevTools: [JsDocValidator] Make sure function receivers agree with @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address misunderstood comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends 1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends
2 * @extends {Base} 2 * @extends {Base}
3 ^ 3 ^
4 4
5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor 5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor
6 DerivedNoProto = function() {} 6 DerivedNoProto = function() {}
7 ^ 7 ^
8 8
9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:16: ERROR - Type DerivedBadProto extends Base but does not properly invoke its constructor 9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:16: ERROR - Type DerivedBadProto extends Base but does not properly invoke its constructor
10 DerivedBadProto = function() {} 10 DerivedBadProto = function() {}
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 ^ 179 ^
180 180
181 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:126: ERROR - @this annotation is required for functions referencing 'this' 181 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:126: ERROR - @this annotation is required for functions referencing 'this'
182 function badCallbackInCtor() { 182 function badCallbackInCtor() {
183 ^ 183 ^
184 184
185 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:146: ERROR - @this annotation is required for functions referencing 'this' 185 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:146: ERROR - @this annotation is required for functions referencing 'this'
186 function badCallbackInMethod() { 186 function badCallbackInMethod() {
187 ^ 187 ^
188 188
189 Total errors: 47 189 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:153: ERROR - @this annotation found for fu nction not referencing 'this'
190 function callbackNotReferencingThis() {
191 ^
192
193 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:191: ERROR - Member function can only be b ound to 'this' as the receiver
194 var badMemberBinding1 = this.memberTwo.bind(null); // ERROR - Member not bound to |this| receiver.
195 ^
196
197 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:192: ERROR - Member function can only be b ound to 'this' as the receiver
198 var badMemberBinding2 = this.memberTwo.bind(bar); // ERROR - Member not bound to |this| receiver.
199 ^
200
201 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:217: ERROR - Receiver not specified for a function annotated with @this
202 callbackWithThis(); // ERROR - No receiver.
203 ^
204
205 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:218: ERROR - Receiver not specified for a function annotated with @this
206 callbackWithThis.call(); // ERROR - No receiver.
207 ^
208
209 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:219: ERROR - Receiver not specified for a function annotated with @this
210 callbackWithThis.call(null); // ERROR - No receiver.
211 ^
212
213 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:220: ERROR - Receiver not specified for a function annotated with @this
214 callbackWithThis.apply(); // ERROR - No receiver.
215 ^
216
217 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:221: ERROR - Receiver not specified for a function annotated with @this
218 callbackWithThis.apply(null); // ERROR - No receiver.
219 ^
220
221 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:222: ERROR - Receiver specified for a func tion not annotated with @this
222 callbackNoThis.call(this); // ERROR - Function has no @this annotation.
223 ^
224
225 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:223: ERROR - Receiver specified for a func tion not annotated with @this
226 callbackNoThis.call(foo); // ERROR - Function has no @this annotation.
227 ^
228
229 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:224: ERROR - Receiver specified for a func tion not annotated with @this
230 callbackNoThis.apply(this); // ERROR - Function has no @this annotation.
231 ^
232
233 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:225: ERROR - Receiver specified for a func tion not annotated with @this
234 callbackNoThis.bind(this); // ERROR - Function has no @this annotation.
235 ^
236
237 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:227: ERROR - Function annotated with @this used as argument without bind(<non-null-receiver>)
238 this.memberTwo(callbackWithThis); // ERROR - Used as argument with no bo und receiver.
239 ^
240
241 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:228: ERROR - Receiver not specified for a function annotated with @this
242 this.memberTwo(callbackWithThis.bind(null, 2)); // ERROR - Used as argum ent with no bound receiver (null means "no receiver").
243 ^
244
245 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:229: ERROR - Receiver specified for a func tion not annotated with @this
246 this.memberTwo(callbackNoThis.bind(this)); // ERROR - Bound to a receive r but has no @this annotation.
247 ^
248
249 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:230: ERROR - Receiver specified for a func tion not annotated with @this
250 this.memberTwo(callbackNoThis.bind(foo)); // ERROR - Bound to a receiver but has no @this annotation.
251 ^
252
253 Total errors: 63
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698