Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2028103002:
Do not try to load material design paks if not on Mac OS. (Closed)
|
Created:
4 years, 6 months ago by mfomitchev Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not try to load material design paks if not on Mac OS.
This gets rid of (harmless) errors when launching Chrome, which are a little
distracting.
BUG=616421
Committed: https://crrev.com/2f3f36758fba0f3436c4eca1370d1f78b7beb981
Cr-Commit-Position: refs/heads/master@{#397430}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressing feedback. #
Total comments: 1
Messages
Total messages: 19 (11 generated)
mfomitchev@chromium.org changed reviewers: + estade@chromium.org, sadrul@chromium.org, tdanderson@chromium.org
lgtm https://codereview.chromium.org/2028103002/diff/1/ui/base/resource/resource_b... File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/2028103002/diff/1/ui/base/resource/resource_b... ui/base/resource/resource_bundle.cc:706: if (MaterialDesignController::IsModeMaterial()) { hmm, is this check necessary on !osx? Can we move the ifdef outside?
https://codereview.chromium.org/2028103002/diff/1/ui/base/resource/resource_b... File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/2028103002/diff/1/ui/base/resource/resource_b... ui/base/resource/resource_bundle.cc:706: if (MaterialDesignController::IsModeMaterial()) { On 2016/06/01 19:14:14, Evan Stade wrote: > hmm, is this check necessary on !osx? Can we move the ifdef outside? Good point. Done.
Description was changed from ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. If the fix for crbug.com/613593 is not going to land soon, it would be good to have this or something similar. BUG=NONE ========== to ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. If the fix for crbug.com/613593 is not going to land soon, it would be good to have this or something similar. BUG=616421 ==========
lgtm https://codereview.chromium.org/2028103002/diff/20001/ui/base/resource/resour... File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/2028103002/diff/20001/ui/base/resource/resour... ui/base/resource/resource_bundle.cc:720: #endif // defined(OS_MACOSX)
The CQ bit was checked by mfomitchev@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org Link to the patchset: https://codereview.chromium.org/2028103002/#ps20001 (title: "Addressing feedback.")
Description was changed from ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. If the fix for crbug.com/613593 is not going to land soon, it would be good to have this or something similar. BUG=616421 ========== to ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. BUG=616421 ==========
The CQ bit was unchecked by mfomitchev@chromium.org
The CQ bit was checked by mfomitchev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028103002/20001
The CQ bit was unchecked by mfomitchev@chromium.org
The CQ bit was checked by mfomitchev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028103002/20001
Message was sent while issue was closed.
Description was changed from ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. BUG=616421 ========== to ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. BUG=616421 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. BUG=616421 ========== to ========== Do not try to load material design paks if not on Mac OS. This gets rid of (harmless) errors when launching Chrome, which are a little distracting. BUG=616421 Committed: https://crrev.com/2f3f36758fba0f3436c4eca1370d1f78b7beb981 Cr-Commit-Position: refs/heads/master@{#397430} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2f3f36758fba0f3436c4eca1370d1f78b7beb981 Cr-Commit-Position: refs/heads/master@{#397430} |
