Revert of Reland: Forward output glitch information from stream WebRTC log

Revert of Reland: Forward output glitch information from stream WebRTC log (patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux Tester bot.

See: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/17602

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
>
> * A callback is added as input parameter on AudioManager create stream functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC log.
> * The Mac input and output streams inform about OS glitches via the callback.
>
> This relands https://codereview.chromium.org/1864483002
>
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL)
>
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT=true

Committed: https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872
Cr-Commit-Position: refs/heads/master@{#397145}

[Guido Urdaneta, 2016-06-01 12:51:38]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-06-01 12:51:38]

Created Revert of Reland: Forward output glitch information from stream WebRTC
log

[commit-bot: I haz the power, 2016-06-01 12:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028053002/1

[commit-bot: I haz the power, 2016-06-01 13:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 13:00:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Guido Urdaneta, 2016-06-01 13:37:08]

Description was changed from

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
==========

to

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT
==========

[Guido Urdaneta, 2016-06-01 13:37:15]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-06-01 13:37:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028053002/1

[commit-bot: I haz the power, 2016-06-01 13:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 13:45:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Guido Urdaneta, 2016-06-01 13:55:56]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-06-01 13:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028053002/1

[commit-bot: I haz the power, 2016-06-01 14:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 14:03:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Guido Urdaneta, 2016-06-01 14:23:19]

Description was changed from

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT
==========

to

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT=true
==========

[Guido Urdaneta, 2016-06-01 14:23:30]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-06-01 14:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028053002/1

[commit-bot: I haz the power, 2016-06-01 14:24:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 14:24:37]

Failed to apply patch for components/audio_modem/audio_recorder_impl.cc:
While running git apply --index -3 -p1;
  error: patch failed: components/audio_modem/audio_recorder_impl.cc:114
  Falling back to three-way merge...
  Applied patch to 'components/audio_modem/audio_recorder_impl.cc' with
conflicts.
  U components/audio_modem/audio_recorder_impl.cc

Patch:       components/audio_modem/audio_recorder_impl.cc
Index: components/audio_modem/audio_recorder_impl.cc
diff --git a/components/audio_modem/audio_recorder_impl.cc
b/components/audio_modem/audio_recorder_impl.cc
index
b5ed82907a28d1baee687db85f244862b6741491..c87cb6e8311a9bb9b2b6a072578ac112f59e58c1
100644
--- a/components/audio_modem/audio_recorder_impl.cc
+++ b/components/audio_modem/audio_recorder_impl.cc
@@ -114,8 +114,7 @@
   stream_ = input_stream_for_testing_
                 ? input_stream_for_testing_.get()
                 : media::AudioManager::Get()->MakeAudioInputStream(
-                      params, media::AudioDeviceDescription::kDefaultDeviceId,
-                      media::AudioManager::LogCallback());
+                      params, media::AudioDeviceDescription::kDefaultDeviceId);
 
   if (!stream_ || !stream_->Open()) {
     LOG(ERROR) << "Failed to open an input stream.";

[Guido Urdaneta, 2016-06-01 15:12:51]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-06-01 15:13:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028053002/1

[commit-bot: I haz the power, 2016-06-01 15:14:35]

Description was changed from

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT=true
==========

to

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-06-01 15:14:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 15:16:06]

Description was changed from

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
> 
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
> 
> This relands https://codereview.chromium.org/1864483002
> 
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
> 
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT=true
==========

to

==========
Revert of Reland: Forward output glitch information from stream WebRTC log
(patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )

Reason for revert:
This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux
Tester bot.

See:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/1...

If the revert doesn't work, I'll reland.

Original issue's description:
> Forward output glitch information from stream WebRTC log
>
> * A callback is added as input parameter on AudioManager create stream
functions.
> * OnLogMessage() function is added to the AudioLog interface.
> * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback
when creating an output stream.
> * AudioInputController gives AudioInputController::LogMessage() (new function)
as callback when creating an input stream. In this function, the message is
passed to AudioInputRendererHost::OnLog().
> * In both input and output cases, the message is then passed to the WebRTC
log.
> * The Mac input and output streams inform about OS glitches via the callback.
>
> This relands https://codereview.chromium.org/1864483002
>
> BUG=610967
> TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged
files from original CL)
>
> Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> Cr-Commit-Position: refs/heads/master@{#396818}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610967
NOPRESUBMIT=true

Committed: https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872
Cr-Commit-Position: refs/heads/master@{#397145}
==========

[commit-bot: I haz the power, 2016-06-01 15:16:07]

Patchset 1 (id:??) landed as
https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872
Cr-Commit-Position: refs/heads/master@{#397145}

[Guido Urdaneta, 2016-06-01 17:10:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2021403003/ by guidou@chromium.org.

The reason for reverting is: The WebRTC Linux Tests bot is still broken after
the revert, so relanding..