Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Issue 2028023002: Use valid log callback for audio modem's audio recorder. (Closed)

Created:
4 years, 6 months ago by Henrik Grunell
Modified:
4 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use valid log callback for audio modem's audio recorder. This fixes a crash. Also change dchecks to checks to catch early. In the unit test we use a mock stream, and there's obviously no (debug built) integration test for this. BUG=616083 TBR=tommi@chromium.org, xiyuan@chromium.org Committed: https://crrev.com/9d6c6d9e13e8c263cf0a16c33eb39065ebb5a6eb Cr-Commit-Position: refs/heads/master@{#397127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M components/audio_modem/audio_recorder_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Henrik Grunell
4 years, 6 months ago (2016-06-01 12:07:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028023002/1
4 years, 6 months ago (2016-06-01 12:11:15 UTC) #6
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-06-01 12:38:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 13:49:35 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9d6c6d9e13e8c263cf0a16c33eb39065ebb5a6eb Cr-Commit-Position: refs/heads/master@{#397127}
4 years, 6 months ago (2016-06-01 13:50:59 UTC) #11
Guido Urdaneta
4 years, 6 months ago (2016-06-01 15:11:23 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2028083002/ by guidou@chromium.org.

The reason for reverting is: Temporarily reverting this, as the revert is
required to revert https://codereview.chromium.org/2022023002/ which is suspect
of causing bot failures.

Will reland if the reverts don't work..

Powered by Google App Engine
This is Rietveld 408576698