Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2028013003: [ios Mojo] Integration test for Mojo WebUI. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
sdefresne, Jackie Quinn
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios Mojo] Integration test for Mojo WebUI. Tests communication between WebUI page and the native code. When page is loaded it sends "syn" message to the native code, when native code receives "syn" it replies back with "ack", when page receives "ack" it replies back with "fin". Once "fin" is received the test succeeds. BUG=567809 TBR=thestig@chromium.org, Review-Url: https://codereview.chromium.org/2006273005 Cr-Commit-Position: refs/heads/master@{#396972} (cherry picked from commit dc9e9709213948d4db6308f71c4097950b9da8fa) Committed: https://crrev.com/b81a4b2c3fd3b535bd01c7c34ebbcdef0a993c66 Cr-Commit-Position: refs/heads/master@{#397240}

Patch Set 1 : Original reverted CL #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -4 lines) Patch
M ios/web/BUILD.gn View 3 chunks +6 lines, -4 lines 0 comments Download
M ios/web/ios_web_inttests.gyp View 1 1 chunk +70 lines, -0 lines 0 comments Download
M ios/web/test/BUILD.gn View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/web/test/data/mojo_test.html View 1 chunk +7 lines, -0 lines 0 comments Download
A ios/web/test/data/mojo_test.js View 1 chunk +63 lines, -0 lines 0 comments Download
A ios/web/test/test_resources.grd View 1 chunk +16 lines, -0 lines 0 comments Download
M ios/web/test/web_test_suite.mm View 1 2 chunks +13 lines, -0 lines 0 comments Download
A ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +164 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028013003/20001
4 years, 6 months ago (2016-06-01 16:25:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 17:44:22 UTC) #4
Eugene But (OOO till 7-30)
Now this CL is safe to land. PTAL.
4 years, 6 months ago (2016-06-01 17:56:58 UTC) #6
Eugene But (OOO till 7-30)
Jackie, could you please take a look. I can reland this now after fixing upstream: ...
4 years, 6 months ago (2016-06-01 20:54:06 UTC) #9
Jackie Quinn
lgtm
4 years, 6 months ago (2016-06-01 20:58:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028013003/20001
4 years, 6 months ago (2016-06-01 21:01:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 21:08:31 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:10:10 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b81a4b2c3fd3b535bd01c7c34ebbcdef0a993c66
Cr-Commit-Position: refs/heads/master@{#397240}

Powered by Google App Engine
This is Rietveld 408576698