Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20280003: Migrate more tests from blink repository. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Migrate more tests from blink repository. The stand-alone test driver is changed a bit: - Don't use the errorMessage list. It is used differently in the embedded driver. There it collects parser errors - instead of failure messages. - Remove html links in description texts. Some test descriptions print a web reference. The migrated tests fall into 3 categories: 1. Tests outside fast/js 2. Tests that print FAIL messages (and also expect those) - these tests should be examined later if they make sense at all 3. Tests with html links in the test description R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13223 lines, -1101 lines) Patch
A test/webkit/fast/js/JSON-parse-reviver.js View 1 chunk +205 lines, -0 lines 0 comments Download
A test/webkit/fast/js/JSON-parse-reviver-expected.txt View 1 chunk +131 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Object-defineProperty.js View 1 chunk +239 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Object-defineProperty-expected.txt View 1 chunk +176 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +135 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +113 lines, -0 lines 0 comments Download
A test/webkit/fast/js/arguments.js View 1 chunk +689 lines, -0 lines 0 comments Download
A test/webkit/fast/js/arguments-expected.txt View 1 chunk +207 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/array-bad-time.js View 1 chunk +22 lines, -13 lines 0 comments Download
A test/webkit/fast/js/array-bad-time-expected.txt View 1 chunk +1034 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/array-float-delete.js View 1 chunk +6 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/array-float-delete-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A test/webkit/fast/js/array-functions-non-arrays.js View 1 chunk +204 lines, -0 lines 0 comments Download
A test/webkit/fast/js/array-functions-non-arrays-expected.txt View 1 chunk +122 lines, -0 lines 0 comments Download
A test/webkit/fast/js/array-prototype-properties.js View 1 chunk +52 lines, -0 lines 0 comments Download
A test/webkit/fast/js/array-prototype-properties-expected.txt View 1 chunk +54 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/array-slow-put.js View 1 chunk +11 lines, -13 lines 0 comments Download
A test/webkit/fast/js/array-slow-put-expected.txt View 1 chunk +133 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/array-tostring-ignore-separator.js View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/webkit/fast/js/array-tostring-ignore-separator-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A test/webkit/fast/js/basic-strict-mode.js View 1 chunk +231 lines, -0 lines 0 comments Download
A test/webkit/fast/js/basic-strict-mode-expected.txt View 1 chunk +237 lines, -0 lines 0 comments Download
A test/webkit/fast/js/caller-property.js View 1 chunk +85 lines, -0 lines 0 comments Download
A test/webkit/fast/js/caller-property-expected.txt View 1 chunk +51 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/date-big-setmonth.js View 1 chunk +4 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/date-big-setmonth-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + test/webkit/fast/js/date-negative-setmonth.js View 1 chunk +4 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/date-negative-setmonth-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + test/webkit/fast/js/date-preserve-milliseconds.js View 1 chunk +16 lines, -25 lines 0 comments Download
A + test/webkit/fast/js/date-preserve-milliseconds-expected.txt View 1 chunk +7 lines, -8 lines 0 comments Download
A + test/webkit/fast/js/date-toisostring.js View 1 chunk +17 lines, -15 lines 0 comments Download
A + test/webkit/fast/js/date-toisostring-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
A + test/webkit/fast/js/end-in-string-escape.js View 1 chunk +5 lines, -7 lines 0 comments Download
A + test/webkit/fast/js/end-in-string-escape-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + test/webkit/fast/js/exception-properties.js View 1 chunk +17 lines, -16 lines 0 comments Download
A + test/webkit/fast/js/exception-properties-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
A + test/webkit/fast/js/exception-registerfile-shrink.js View 1 chunk +4 lines, -4 lines 0 comments Download
A + test/webkit/fast/js/exception-registerfile-shrink-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + test/webkit/fast/js/excessive-comma-usage.js View 1 chunk +16 lines, -17 lines 0 comments Download
A + test/webkit/fast/js/excessive-comma-usage-expected.txt View 1 chunk +4 lines, -8 lines 0 comments Download
A test/webkit/fast/js/function-apply.js View 1 chunk +318 lines, -0 lines 0 comments Download
A test/webkit/fast/js/function-apply-expected.txt View 1 chunk +66 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/function-constructor-error.js View 1 chunk +3 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/function-constructor-error-expected.txt View 1 chunk +3 lines, -8 lines 0 comments Download
A test/webkit/fast/js/function-toString-parentheses.js View 1 chunk +234 lines, -0 lines 0 comments Download
A test/webkit/fast/js/function-toString-parentheses-expected.txt View 1 chunk +525 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/function-toString-semicolon-insertion.js View 1 chunk +7 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/function-toString-semicolon-insertion-expected.txt View 1 chunk +9 lines, -5 lines 0 comments Download
A + test/webkit/fast/js/modify-non-references.js View 1 chunk +12 lines, -23 lines 0 comments Download
A test/webkit/fast/js/modify-non-references-expected.txt View 1 chunk +39 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/native-error-prototype.js View 1 chunk +10 lines, -26 lines 0 comments Download
A + test/webkit/fast/js/native-error-prototype-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
A test/webkit/fast/js/number-toString.js View 1 chunk +93 lines, -0 lines 0 comments Download
A test/webkit/fast/js/number-toString-expected.txt View 1 chunk +84 lines, -0 lines 0 comments Download
A test/webkit/fast/js/number-tofixed.js View 1 chunk +102 lines, -0 lines 0 comments Download
A test/webkit/fast/js/number-tofixed-expected.txt View 1 chunk +84 lines, -0 lines 0 comments Download
A test/webkit/fast/js/number-toprecision.js View 1 chunk +65 lines, -0 lines 0 comments Download
A test/webkit/fast/js/number-toprecision-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/numeric-escapes-in-string-literals.js View 1 chunk +35 lines, -18 lines 0 comments Download
A test/webkit/fast/js/numeric-escapes-in-string-literals-expected.txt View 1 chunk +68 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/object-bad-time.js View 1 chunk +25 lines, -29 lines 0 comments Download
A test/webkit/fast/js/object-bad-time-expected.txt View 1 chunk +1034 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/object-extra-comma.js View 1 chunk +8 lines, -11 lines 0 comments Download
A + test/webkit/fast/js/object-extra-comma-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/webkit/fast/js/object-prototype-constructor.js View 1 chunk +14 lines, -27 lines 0 comments Download
A + test/webkit/fast/js/object-prototype-constructor-expected.txt View 1 chunk +7 lines, -4 lines 0 comments Download
A + test/webkit/fast/js/object-prototype-properties.js View 1 chunk +10 lines, -16 lines 0 comments Download
A + test/webkit/fast/js/object-prototype-properties-expected.txt View 1 chunk +8 lines, -13 lines 0 comments Download
A + test/webkit/fast/js/object-prototype-toLocaleString.js View 1 chunk +10 lines, -27 lines 0 comments Download
A + test/webkit/fast/js/object-prototype-toLocaleString-expected.txt View 1 chunk +5 lines, -8 lines 0 comments Download
A + test/webkit/fast/js/object-slow-put.js View 1 chunk +14 lines, -11 lines 0 comments Download
A test/webkit/fast/js/object-slow-put-expected.txt View 1 chunk +133 lines, -0 lines 0 comments Download
A test/webkit/fast/js/parser-syntax-check.js View 1 chunk +403 lines, -0 lines 0 comments Download
A test/webkit/fast/js/parser-syntax-check-expected.txt View 1 chunk +611 lines, -0 lines 0 comments Download
A test/webkit/fast/js/primitive-property-access-edge-cases.js View 1 chunk +238 lines, -0 lines 0 comments Download
A test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt View 1 chunk +81 lines, -0 lines 0 comments Download
A test/webkit/fast/js/read-modify-eval.js View 1 chunk +169 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/read-modify-eval-expected.txt View 1 chunk +18 lines, -9 lines 0 comments Download
A + test/webkit/fast/js/regexp-bol.js View 1 chunk +23 lines, -14 lines 0 comments Download
A + test/webkit/fast/js/regexp-bol-expected.txt View 1 chunk +22 lines, -11 lines 0 comments Download
A + test/webkit/fast/js/regexp-bol-with-multiline.js View 1 chunk +7 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/regexp-bol-with-multiline-expected.txt View 1 chunk +6 lines, -4 lines 0 comments Download
A + test/webkit/fast/js/regexp-extended-characters-crash.js View 1 chunk +8 lines, -27 lines 0 comments Download
A + test/webkit/fast/js/regexp-extended-characters-crash-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/webkit/fast/js/regexp-lastindex.js View 1 chunk +8 lines, -9 lines 0 comments Download
A + test/webkit/fast/js/regexp-lastindex-expected.txt View 1 chunk +3 lines, -8 lines 0 comments Download
A + test/webkit/fast/js/regexp-look-ahead.js View 1 chunk +3 lines, -10 lines 0 comments Download
A + test/webkit/fast/js/regexp-look-ahead-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
A test/webkit/fast/js/regexp-no-extensions.js View 1 chunk +69 lines, -0 lines 0 comments Download
A test/webkit/fast/js/regexp-no-extensions-expected.txt View 1 chunk +69 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/regexp-non-capturing-groups.js View 1 chunk +16 lines, -18 lines 0 comments Download
A + test/webkit/fast/js/regexp-non-capturing-groups-expected.txt View 1 chunk +15 lines, -12 lines 0 comments Download
A + test/webkit/fast/js/regexp-non-greedy-parentheses.js View 1 chunk +9 lines, -29 lines 0 comments Download
A + test/webkit/fast/js/regexp-non-greedy-parentheses-expected.txt View 1 chunk +9 lines, -5 lines 0 comments Download
A + test/webkit/fast/js/regexp-range-out-of-order.js View 1 chunk +3 lines, -7 lines 0 comments Download
A + test/webkit/fast/js/regexp-range-out-of-order-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
A test/webkit/fast/js/regexp-ranges-and-escaped-hyphens.js View 1 chunk +75 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/regexp-ranges-and-escaped-hyphens-expected.txt View 1 chunk +18 lines, -7 lines 0 comments Download
A test/webkit/fast/js/regexp-stack-overflow.js View 1 chunk +34 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/regexp-stack-overflow-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A test/webkit/fast/js/regexp-unicode-handling.js View 1 chunk +128 lines, -0 lines 0 comments Download
A test/webkit/fast/js/regexp-unicode-handling-expected.txt View 1 chunk +72 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/reserved-words-strict.js View 3 chunks +16 lines, -46 lines 0 comments Download
A + test/webkit/fast/js/reserved-words-strict-expected.txt View 2 chunks +10 lines, -44 lines 0 comments Download
A + test/webkit/fast/js/stack-overflow-arrity-catch.js View 1 chunk +36 lines, -31 lines 0 comments Download
A + test/webkit/fast/js/stack-overflow-arrity-catch-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A test/webkit/fast/js/string-capitalization.js View 1 chunk +95 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/string-capitalization-expected.txt View 1 chunk +22 lines, -10 lines 0 comments Download
A test/webkit/fast/js/string-split-conformance.js View 1 chunk +96 lines, -0 lines 0 comments Download
A test/webkit/fast/js/string-split-conformance-expected.txt View 1 chunk +90 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/string-split-double-empty.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + test/webkit/fast/js/string-split-double-empty-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
A + test/webkit/fast/js/string-split-ignore-case.js View 1 chunk +2 lines, -3 lines 0 comments Download
A + test/webkit/fast/js/string-split-ignore-case-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + test/webkit/fast/js/toString-exception.js View 1 chunk +14 lines, -4 lines 0 comments Download
A + test/webkit/fast/js/toString-exception-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + test/webkit/fast/js/toString-overrides.js View 1 chunk +37 lines, -19 lines 0 comments Download
A + test/webkit/fast/js/toString-overrides-expected.txt View 1 chunk +8 lines, -5 lines 0 comments Download
A + test/webkit/fast/regex/alternative-length-miscalculation.js View 1 chunk +6 lines, -7 lines 0 comments Download
A + test/webkit/fast/regex/alternative-length-miscalculation-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
A test/webkit/fast/regex/assertion.js View 1 chunk +110 lines, -0 lines 0 comments Download
A + test/webkit/fast/regex/assertion-expected.txt View 1 chunk +38 lines, -5 lines 0 comments Download
A + test/webkit/fast/regex/constructor.js View 1 chunk +6 lines, -9 lines 0 comments Download
A + test/webkit/fast/regex/constructor-expected.txt View 1 chunk +5 lines, -8 lines 0 comments Download
A test/webkit/fast/regex/dotstar.js View 1 chunk +160 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/dotstar-expected.txt View 1 chunk +141 lines, -0 lines 0 comments Download
A + test/webkit/fast/regex/early-acid3-86.js View 1 chunk +7 lines, -9 lines 0 comments Download
A + test/webkit/fast/regex/early-acid3-86-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A + test/webkit/fast/regex/ecma-regex-examples.js View 1 chunk +25 lines, -33 lines 0 comments Download
A + test/webkit/fast/regex/ecma-regex-examples-expected.txt View 1 chunk +13 lines, -10 lines 0 comments Download
A + test/webkit/fast/regex/invalid-range-in-class.js View 1 chunk +19 lines, -46 lines 0 comments Download
A + test/webkit/fast/regex/invalid-range-in-class-expected.txt View 1 chunk +12 lines, -5 lines 0 comments Download
A test/webkit/fast/regex/lastIndex.js View 1 chunk +71 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/lastIndex-expected.txt View 1 chunk +53 lines, -0 lines 0 comments Download
A + test/webkit/fast/regex/malformed-escapes.js View 1 chunk +35 lines, -30 lines 0 comments Download
A + test/webkit/fast/regex/malformed-escapes-expected.txt View 1 chunk +32 lines, -8 lines 0 comments Download
A + test/webkit/fast/regex/non-capturing-backtracking.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + test/webkit/fast/regex/non-capturing-backtracking-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + test/webkit/fast/regex/overflow.js View 1 chunk +11 lines, -13 lines 0 comments Download
A + test/webkit/fast/regex/overflow-expected.txt View 1 chunk +5 lines, -8 lines 0 comments Download
A test/webkit/fast/regex/parentheses.js View 1 chunk +277 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/parentheses-expected.txt View 1 chunk +124 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/pcre-test-4.js View 1 chunk +1169 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/pcre-test-4-expected.txt View 1 chunk +275 lines, -0 lines 0 comments Download
A + test/webkit/fast/regex/quantified-assertions.js View 1 chunk +19 lines, -24 lines 0 comments Download
A + test/webkit/fast/regex/quantified-assertions-expected.txt View 1 chunk +17 lines, -6 lines 0 comments Download
A + test/webkit/fast/regex/repeat-match-waldemar.js View 1 chunk +22 lines, -47 lines 0 comments Download
A + test/webkit/fast/regex/repeat-match-waldemar-expected.txt View 1 chunk +22 lines, -12 lines 0 comments Download
A test/webkit/fast/regex/toString.js View 1 chunk +87 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/toString-expected.txt View 1 chunk +60 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/unicodeCaseInsensitive.js View 1 chunk +101 lines, -0 lines 0 comments Download
A test/webkit/fast/regex/unicodeCaseInsensitive-expected.txt View 1 chunk +349 lines, -0 lines 0 comments Download
M test/webkit/resources/standalone-pre.js View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-25 14:38:23 UTC) #1
Jakob Kummerow
LGTM (reviewed test/webkit/resources/standalone-pre.js in detail, rubberstamping the tests themselves).
7 years, 5 months ago (2013-07-25 16:27:18 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-25 19:55:25 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r15889 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698