Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2027983002: Revert of [ios Mojo] Integration test for Mojo WebUI. (Closed)

Created:
4 years, 6 months ago by stkhapugin
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios Mojo] Integration test for Mojo WebUI. (patchset #9 id:160001 of https://codereview.chromium.org/2006273005/ ) Reason for revert: Breaks downstream ios_internal_unittests execution because ios_internal_unittests already has resource load code and the bundle ends up being loaded twice. Please remove this code downstream, also see comments in code review tool. Original issue's description: > [ios Mojo] Integration test for Mojo WebUI. > > Tests communication between WebUI page and the native code. > When page is loaded it sends "syn" message to the native code, > when native code receives "syn" it replies back with "ack", > when page receives "ack" it replies back with "fin". Once "fin" is > received the test succeeds. > > BUG=567809 > > Committed: https://crrev.com/dc9e9709213948d4db6308f71c4097950b9da8fa > Cr-Commit-Position: refs/heads/master@{#396972} TBR=rockot@chromium.org,jyquinn@chromium.org,sdefresne@chromium.org,thestig@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=567809 Committed: https://crrev.com/052e2287db6cf226e41a4bc91123a604462e1619 Cr-Commit-Position: refs/heads/master@{#397104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -388 lines) Patch
M ios/web/BUILD.gn View 3 chunks +5 lines, -7 lines 0 comments Download
M ios/web/ios_web_inttests.gyp View 1 chunk +0 lines, -82 lines 0 comments Download
M ios/web/test/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/web/test/data/mojo_test.html View 1 chunk +0 lines, -7 lines 0 comments Download
D ios/web/test/data/mojo_test.js View 1 chunk +0 lines, -63 lines 0 comments Download
D ios/web/test/test_resources.grd View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/web/test/web_test_suite.mm View 2 chunks +0 lines, -9 lines 0 comments Download
D ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +0 lines, -164 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
stkhapugin
Created Revert of [ios Mojo] Integration test for Mojo WebUI.
4 years, 6 months ago (2016-06-01 09:47:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027983002/1
4 years, 6 months ago (2016-06-01 09:47:35 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-01 09:47:37 UTC) #5
lpromero
lgtm
4 years, 6 months ago (2016-06-01 11:07:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027983002/1
4 years, 6 months ago (2016-06-01 11:07:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 11:08:36 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 11:10:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/052e2287db6cf226e41a4bc91123a604462e1619
Cr-Commit-Position: refs/heads/master@{#397104}

Powered by Google App Engine
This is Rietveld 408576698