Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: content/browser/media/webrtc/webrtc_datachannel_browsertest.cc

Issue 2027963002: Disable WebRTC DataChannel GC test on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc/webrtc_datachannel_browsertest.cc
diff --git a/content/browser/media/webrtc/webrtc_datachannel_browsertest.cc b/content/browser/media/webrtc/webrtc_datachannel_browsertest.cc
index fb38cc7145847ffa5791808b6f45971a9761a9b9..9f72ab836acf463c4f85c9a4468de3a868dd93ba 100644
--- a/content/browser/media/webrtc/webrtc_datachannel_browsertest.cc
+++ b/content/browser/media/webrtc/webrtc_datachannel_browsertest.cc
@@ -16,9 +16,10 @@ const char kDataChannelHtmlFile[] = "/media/datachannel_test.html";
namespace content {
-#if defined(OS_ANDROID) && defined(ADDRESS_SANITIZER)
+#if defined(OS_WIN) || (defined(OS_ANDROID) && defined(ADDRESS_SANITIZER))
// GC does not work correctly in some cases under Android ASAN.
// See https://crbug.com/611620.
+// This test has become flaky on Windows. See https://crbug.com/616388
#define MAYBE_WebRtcDataChannelTest DISABLED_WebRtcDataChannelTest
#else
#define MAYBE_WebRtcDataChannelTest WebRtcDataChannelTest
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698