Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2027953002: Revert of Clear ui::Layer damaged_region_ after commit. (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
Reviewers:
danakj, jbauman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clear ui::Layer damaged_region_ after commit. (patchset #2 id:20001 of https://codereview.chromium.org/2018223002/ ) Reason for revert: This CL is suspect of breaking Linux Tests bots. See crbug.com/616387 I will reland if the revert doesn't fix the bots. Original issue's description: > Clear ui::Layer damaged_region_ after commit. > > This was only being cleared for ui::Layers with PictureLayers and not > those with TextureLayers, so all frames afterwards would have > unnecessary damage. > > BUG=610086 > > Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e > Cr-Commit-Position: refs/heads/master@{#396936} TBR=danakj@chromium.org,jbauman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610086 Committed: https://crrev.com/187e03fd3f2366163f35b40f8f0785d9ba0e643f Cr-Commit-Position: refs/heads/master@{#397080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -37 lines) Patch
M ui/compositor/layer.h View 3 chunks +2 lines, -9 lines 0 comments Download
M ui/compositor/layer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of Clear ui::Layer damaged_region_ after commit.
4 years, 6 months ago (2016-06-01 08:06:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027953002/1
4 years, 6 months ago (2016-06-01 08:06:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 08:07:10 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 08:08:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/187e03fd3f2366163f35b40f8f0785d9ba0e643f
Cr-Commit-Position: refs/heads/master@{#397080}

Powered by Google App Engine
This is Rietveld 408576698