Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 2027933002: Allow transitions on background-size with positionally matched keywords (Closed)

Created:
3 years ago by alancutter (OOO until 2018)
Modified:
3 years ago
Reviewers:
dstockwell
CC:
Abhishek Kanike, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow transitions on background-size with positionally matched keywords This change allows CSS transitions to interpolate between lists with matching keywords. This affects interpolation for the following properties: - border-image-width This property is not animatable according to spec: https://drafts.csswg.org/css-backgrounds-3/#the-border-image-width - background-size Values are now interpolable if their keywords are positionally matched: https://github.com/w3c/csswg-drafts/commit/a5f9de921fa7834c79ee15660d9d86528bce1607 - -webkit-background-size - -webkit-mask-size These mirror the animation behaviour of background-size. This change only affects CSS Transitions for the sake of a small mergable patch. CSS Animations behaviour will be brought in line in a separate patch. This change ensures we have compatible behaviour with other browsers for transitioning between single length background-size values e.g. "background-size: 50%" to "background-size: 100%" BUG=616072 Committed: https://crrev.com/8793a7bac4d2d56e38c8bd406920128e1ceb7a9a Cr-Commit-Position: refs/heads/master@{#397661}

Patch Set 1 #

Patch Set 2 : outline #

Patch Set 3 : Inline is required #

Messages

Total messages: 18 (9 generated)
alancutter (OOO until 2018)
Assigning to dstockwell for review of behaviour change (intended to merge with 52 and 51).
3 years ago (2016-06-01 07:40:27 UTC) #2
alancutter (OOO until 2018)
Updated description to reflect recent spec change.
3 years ago (2016-06-03 00:46:55 UTC) #5
dstockwell
lgtm
3 years ago (2016-06-03 00:49:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027933002/20001
3 years ago (2016-06-03 01:35:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/76093) cast_shell_android on tryserver.chromium.android (JOB_FAILED, ...
3 years ago (2016-06-03 01:49:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027933002/20001
3 years ago (2016-06-03 02:24:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027933002/40001
3 years ago (2016-06-03 02:51:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years ago (2016-06-03 08:12:19 UTC) #16
commit-bot: I haz the power
3 years ago (2016-06-03 08:14:39 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8793a7bac4d2d56e38c8bd406920128e1ceb7a9a
Cr-Commit-Position: refs/heads/master@{#397661}

Powered by Google App Engine
This is Rietveld 408576698