Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2027923002: Add strictmode disk read/write exemption for calls to show hide keyboard (Closed)

Created:
4 years, 6 months ago by Changwan Ryu
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strictmode disk read/write exemption for calls to show hide keyboard InputMethodManagerService in Android platform sometimes access disk to record the IME state. This prevents crashes in dev. BUG=616283 Committed: https://crrev.com/9cde65f3edabcbcd41e5b581a802672705c69a93 Cr-Commit-Position: refs/heads/master@{#397224}

Patch Set 1 #

Total comments: 2

Patch Set 2 : do not import StrictMode.ThreadPolicy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java View 1 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Changwan Ryu
4 years, 6 months ago (2016-06-01 07:30:02 UTC) #2
Peter Wen
lgtm https://codereview.chromium.org/2027923002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java File content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java (right): https://codereview.chromium.org/2027923002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java#newcode54 content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java:54: ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites(); // crbug.com/616283 nit: Use ...
4 years, 6 months ago (2016-06-01 13:53:32 UTC) #3
Changwan Ryu
https://codereview.chromium.org/2027923002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java File content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java (right): https://codereview.chromium.org/2027923002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java#newcode54 content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java:54: ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites(); // crbug.com/616283 On 2016/06/01 13:53:32, ...
4 years, 6 months ago (2016-06-01 15:00:48 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 6 months ago (2016-06-01 19:08:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027923002/20001
4 years, 6 months ago (2016-06-01 20:08:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 20:14:46 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:20:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cde65f3edabcbcd41e5b581a802672705c69a93
Cr-Commit-Position: refs/heads/master@{#397224}

Powered by Google App Engine
This is Rietveld 408576698