Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2027883002: Fix PrivetNotificationService::PrivetNotify() silliness. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PrivetNotificationService::PrivetNotify() silliness. BUG=540847 Committed: https://crrev.com/fb0fd2cfd895efb50f6645f2177d9bf0639451d6 Cr-Commit-Position: refs/heads/master@{#397187}

Patch Set 1 : Fix crazy formatting in unit test #

Total comments: 1

Patch Set 2 : Get rid of excess blank lines #

Patch Set 3 : nits #

Patch Set 4 : Add unit test to hit -1 new printers case #

Total comments: 1

Patch Set 5 : Fix bug, fix unit test #

Total comments: 1

Patch Set 6 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -124 lines) Patch
M chrome/browser/printing/cloud_print/privet_notifications.cc View 1 2 3 4 5 9 chunks +58 lines, -61 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_notifications_unittest.cc View 1 2 3 4 chunks +37 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
https://codereview.chromium.org/2027883002/diff/1/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc File chrome/browser/printing/cloud_print/privet_notifications_unittest.cc (right): https://codereview.chromium.org/2027883002/diff/1/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc#newcode72 chrome/browser/printing/cloud_print/privet_notifications_unittest.cc:72: : request_context_(request_context) {} I let "git cl format" reformat ...
4 years, 6 months ago (2016-06-01 02:15:17 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 6 months ago (2016-06-01 18:02:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027883002/100001
4 years, 6 months ago (2016-06-01 18:11:05 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-01 18:15:28 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 18:17:08 UTC) #8
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/fb0fd2cfd895efb50f6645f2177d9bf0639451d6
Cr-Commit-Position: refs/heads/master@{#397187}

Powered by Google App Engine
This is Rietveld 408576698