Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2027873006:
Fix an unitialized variable warning in Brotli. (Closed)
|
Created:
4 years, 6 months ago by Sébastien Marchand Modified:
4 years, 6 months ago Reviewers:
Kunihiko Sakamoto CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix an unitialized variable warning in Brotli.
Correspond to https://github.com/google/brotli/commit/c6d38e94cbf9ec094b1e84f6a3a675c9dc42fbed
Committed: https://crrev.com/fba4cf03d215accdb66287ab0102a2a4a34f1a1f
Cr-Commit-Position: refs/heads/master@{#397397}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Dependent Patchsets: Messages
Total messages: 22 (10 generated)
sebmarchand@chromium.org changed reviewers: + ksakamoto@chromium.org
PTAL.
lgtm with a comment https://codereview.chromium.org/2027873006/diff/1/third_party/brotli/README.c... File third_party/brotli/README.chromium (right): https://codereview.chromium.org/2027873006/diff/1/third_party/brotli/README.c... third_party/brotli/README.chromium:27: - Line 1158 of enc/encode.cc has been modified to fix an unitialized variable Please mention that this is a cherry-pick of c6d38e94cbf9ec094b1e84f6a3a675c9dc42fbed.
https://codereview.chromium.org/2027873006/diff/1/third_party/brotli/README.c... File third_party/brotli/README.chromium (right): https://codereview.chromium.org/2027873006/diff/1/third_party/brotli/README.c... third_party/brotli/README.chromium:27: - Line 1158 of enc/encode.cc has been modified to fix an unitialized variable On 2016/06/02 01:15:26, Kunihiko Sakamoto wrote: > Please mention that this is a cherry-pick of > c6d38e94cbf9ec094b1e84f6a3a675c9dc42fbed. Done.
The CQ bit was checked by sebmarchand@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ksakamoto@chromium.org Link to the patchset: https://codereview.chromium.org/2027873006/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027873006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027873006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027873006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027873006/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix an unitialized variable warning in Brotli. Correspond to https://github.com/google/brotli/commit/c6d38e94cbf9ec094b1e84f6a3a675c9dc42fbed ========== to ========== Fix an unitialized variable warning in Brotli. Correspond to https://github.com/google/brotli/commit/c6d38e94cbf9ec094b1e84f6a3a675c9dc42fbed Committed: https://crrev.com/fba4cf03d215accdb66287ab0102a2a4a34f1a1f Cr-Commit-Position: refs/heads/master@{#397397} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fba4cf03d215accdb66287ab0102a2a4a34f1a1f Cr-Commit-Position: refs/heads/master@{#397397} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
