Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3256)

Unified Diff: chrome/test/BUILD.gn

Issue 2027873002: Enable telemetry_perf_unittests on swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address kbr's comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 7778f1dfb4d94fce0c1278addd4e94380d988038..6231c9ca552876a454ce32e9a12caad50e9a1e9b 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -735,29 +735,6 @@ if (!is_android) {
# TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
- group("telemetry_perf_unittests_run") {
ghost stip (do not use) 2016/06/01 08:42:25 move these out of the if (!is_android) block
- testonly = true
- deps = [
- ":telemetry_perf_unittests",
- ]
- }
-
- group("telemetry_perf_unittests") {
- testonly = true
- deps = [
- "//tools/perf:perf",
- ]
-
- data = [
- # For isolate contract.
- "//testing/scripts/common.py",
- "//testing/xvfb.py",
- "//testing/scripts/run_telemetry_as_googletest.py",
- ]
- }
-
- # TODO(GYP_GONE): Delete this after we've converted everything to GN.
- # The _run targets exist only for compatibility w/ GYP.
group("telemetry_unittests_run") {
testonly = true
deps = [
@@ -1624,6 +1601,29 @@ if (!is_android) {
}
}
+# TODO(GYP_GONE): Delete this after we've converted everything to GN.
+# The _run targets exist only for compatibility w/ GYP.
+group("telemetry_perf_unittests_run") {
+ testonly = true
+ deps = [
+ ":telemetry_perf_unittests",
+ ]
+}
+
+group("telemetry_perf_unittests") {
+ testonly = true
+ deps = [
+ "//tools/perf:perf",
+ ]
+
+ data = [
+ # For isolate contract.
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_telemetry_as_googletest.py",
+ ]
+}
+
js2gtest("unit_tests_js") {
test_type = "unit"
sources = rebase_path(

Powered by Google App Engine
This is Rietveld 408576698