Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2027843004: tools/android/loading Prevent gcloud instance leak. (Closed)

Created:
4 years, 6 months ago by droger
Modified:
4 years, 6 months ago
Reviewers:
Benoit L, blundell
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@reportName
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading Prevent gcloud instance leak. This CL moves the instance creation at the end of the process, in order to avoid creating instances if the task is not valid. It also schedules the polling task responsible for cleaning up the instances before actually creating them so that this cleanup task is run even if something goes wrong during the instance creation process. Committed: https://crrev.com/9081ca13fdb637f8897d99c346c947bd4dd4e31d Cr-Commit-Position: refs/heads/master@{#397126}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M tools/android/loading/cloud/frontend/clovis_frontend.py View 1 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
droger
4 years, 6 months ago (2016-06-01 11:41:31 UTC) #2
Benoit L
On 2016/06/01 11:41:31, droger wrote: lgtm
4 years, 6 months ago (2016-06-01 11:58:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027843004/20001
4 years, 6 months ago (2016-06-01 13:03:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 13:47:19 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:49:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9081ca13fdb637f8897d99c346c947bd4dd4e31d
Cr-Commit-Position: refs/heads/master@{#397126}

Powered by Google App Engine
This is Rietveld 408576698