Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2027803003: cc: Destroy pending_tree_duration_timer_ when reseting trees (Closed)

Created:
4 years, 6 months ago by ajuma
Modified:
4 years, 6 months ago
Reviewers:
Ian Vollick, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Destroy pending_tree_duration_timer_ when reseting trees This fixes a DCHECK during TileManagerPerfTests. LTHI::ResetTreesForTesting destroys the pending tree, so if it doesn't also destroy the pending tree duration timer, the next call to CreatePendingTree will fail the DCHECK that the timer doesn't already exist. BUG=607818 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/234a1a16b8e3641a4d3e065344a8cc32b5ea431f Cr-Commit-Position: refs/heads/master@{#397180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ajuma
4 years, 6 months ago (2016-06-01 15:57:22 UTC) #4
Ian Vollick
lgtm
4 years, 6 months ago (2016-06-01 15:59:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027803003/1
4 years, 6 months ago (2016-06-01 16:48:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 17:58:06 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 18:00:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/234a1a16b8e3641a4d3e065344a8cc32b5ea431f
Cr-Commit-Position: refs/heads/master@{#397180}

Powered by Google App Engine
This is Rietveld 408576698