Issue 20278: Fix display of secondary graphs (any besides page-load-time) in perf overview...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20278: Fix display of secondary graphs (any besides page-load-time) in perf overview... (Closed)

Created:
11 years, 10 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix display of secondary graphs (any besides page-load-time) in perf overview by updating URLs passed to the individual graphs. BUG=7597 TEST=click on one of the links at the top of the perf overview page Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9618

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	tools/buildbot/perf/dashboard/overview.html	View		3 chunks	+11 lines, -11 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/20278/diff/1/2 File tools/buildbot/perf/dashboard/overview.html (right): http://codereview.chromium.org/20278/diff/1/2#newcode34 Line 34: <a href="overview.html?graph=vm_peak_b">vm-peak-browser</a> | Maybe these should be ...

11 years, 10 months ago (2009-02-11 22:49:49 UTC) #2

Pam (message me for reviews)

11 years, 10 months ago (2009-02-11 22:51:42 UTC) #3

On 2009/02/11 22:49:49, pkasting wrote:
> LGTM
> 
> http://codereview.chromium.org/20278/diff/1/2
> File tools/buildbot/perf/dashboard/overview.html (right):
> 
> http://codereview.chromium.org/20278/diff/1/2#newcode34
> Line 34: <a href="overview.html?graph=vm_peak_b">vm-peak-browser</a> |
> Maybe these should be named "vm_peak_b", etc.?  Up to you

I thought about it, but decided that the mismatch in names was less confusing
than not being able to tell what the code meant in the first place. If that
turns out not to be the case, we can adjust them later.

- Pam

Expand Messages | Collapse Messages