Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2027783002: Revert of [Android Client] Move session-scoped native interface into JniClient (Closed)

Created:
4 years, 6 months ago by Yuwei
Modified:
4 years, 6 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android Client] Move session-scoped native interface into JniClient (patchset #3 id:60001 of https://codereview.chromium.org/2007403002/ ) Reason for revert: Revert this patch so that a fix for random crashes can land on M52 without conflicts. Original issue's description: > [Android Client] Move session-scoped native interface into JniClient > > This finishes up the refactorization of the JNI interface. Scheduled tasks > inside a session will not be lingering after the session ends. > > BUG=526336 > > Committed: https://crrev.com/800991e54ced74fc425843070a1941827af5b787 > Cr-Commit-Position: refs/heads/master@{#396036} TBR=lambroslambrou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=526336 Committed: https://crrev.com/ff63a5a06c29a20106459ff3f4efee0ec208e5ed Cr-Commit-Position: refs/heads/master@{#396922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -597 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/jni/Client.java View 22 chunks +51 lines, -96 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 4 chunks +154 lines, -5 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 3 chunks +0 lines, -4 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 10 chunks +15 lines, -18 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.h View 2 chunks +67 lines, -0 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 5 chunks +274 lines, -0 lines 0 comments Download
M remoting/client/jni/jni_client.h View 1 chunk +2 lines, -159 lines 0 comments Download
M remoting/client/jni/jni_client.cc View 2 chunks +4 lines, -301 lines 0 comments Download
M remoting/client/jni/jni_frame_consumer.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/client/jni/jni_frame_consumer.cc View 5 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yuwei
Created Revert of [Android Client] Move session-scoped native interface into JniClient
4 years, 6 months ago (2016-05-31 19:27:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027783002/1
4 years, 6 months ago (2016-05-31 19:28:09 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-31 19:28:11 UTC) #5
Lambros
lgtm
4 years, 6 months ago (2016-05-31 19:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027783002/1
4 years, 6 months ago (2016-05-31 19:30:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:45:41 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:46:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff63a5a06c29a20106459ff3f4efee0ec208e5ed
Cr-Commit-Position: refs/heads/master@{#396922}

Powered by Google App Engine
This is Rietveld 408576698